Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1584573002: refactor BlockVisitor in asm to wasm and fix tests (Closed)

Created:
4 years, 11 months ago by aseemgarg
Modified:
4 years, 11 months ago
Reviewers:
titzer, bradnelson, bradn
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

refactor BlockVisitor in asm to wasm and fix tests TEST=asm-wasm.js R=titzer@chromium.org,bradnelson@google.com BUG= Committed: https://crrev.com/cd646f88a158dd21e5257fdd588bcbda0d6e56be Cr-Commit-Position: refs/heads/master@{#33253}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M src/wasm/asm-wasm-builder.cc View 7 chunks +13 lines, -13 lines 0 comments Download
M test/mjsunit/wasm/asm-wasm.js View 5 chunks +5 lines, -5 lines 0 comments Download

Dependent Patchsets:

Issue 1583603002 Patch 1
Issue 1583603002 Patch 20001

Messages

Total messages: 8 (3 generated)
aseemgarg
4 years, 11 months ago (2016-01-12 21:29:19 UTC) #1
bradnelson
lgtm
4 years, 11 months ago (2016-01-12 21:30:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1584573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1584573002/1
4 years, 11 months ago (2016-01-12 21:31:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-12 21:59:19 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 21:59:59 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/cd646f88a158dd21e5257fdd588bcbda0d6e56be
Cr-Commit-Position: refs/heads/master@{#33253}

Powered by Google App Engine
This is Rietveld 408576698