Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 1583603002: Add __init__ function to all modules created in asm-to-wasm (Closed)

Created:
4 years, 11 months ago by aseemgarg
Modified:
4 years, 11 months ago
Reviewers:
titzer, bradnelson, bradn
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@refactor
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add __init__ function to all modules created in asm-to-wasm TEST=asm-wasm.js R=titzer@chromium.org,bradnelson@google.com BUG= Committed: https://crrev.com/9933b03de81badd8731f46db44fa74b4ec80cf83 Cr-Commit-Position: refs/heads/master@{#33256}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -42 lines) Patch
M src/wasm/asm-wasm-builder.cc View 1 6 chunks +31 lines, -25 lines 0 comments Download
M src/wasm/encoder.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/wasm/encoder.cc View 1 3 chunks +14 lines, -14 lines 0 comments Download
M test/mjsunit/wasm/asm-wasm.js View 1 1 chunk +26 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (3 generated)
aseemgarg
4 years, 11 months ago (2016-01-12 21:48:18 UTC) #1
bradn
Add a test?
4 years, 11 months ago (2016-01-12 21:55:30 UTC) #2
aseemgarg
On 2016/01/12 21:55:30, bradn wrote: > Add a test? done! Also fixed function naming in ...
4 years, 11 months ago (2016-01-12 23:52:16 UTC) #3
bradnelson
lgtm
4 years, 11 months ago (2016-01-13 00:29:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1583603002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1583603002/20001
4 years, 11 months ago (2016-01-13 00:29:59 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-13 01:23:49 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-13 01:24:04 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9933b03de81badd8731f46db44fa74b4ec80cf83
Cr-Commit-Position: refs/heads/master@{#33256}

Powered by Google App Engine
This is Rietveld 408576698