Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1584543002: dart2js cps: Support inlining constructors with type arguments. (Closed)

Created:
4 years, 11 months ago by asgerf
Modified:
4 years, 1 month ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Support inlining constructors with type arguments. BUG=

Patch Set 1 #

Patch Set 2 : Update status files and unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -55 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart View 13 chunks +37 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/inline.dart View 4 chunks +8 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/scalar_replacement.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/codegen.dart View 1 chunk +2 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 chunk +1 line, -0 lines 0 comments Download
M tests/compiler/dart2js/cps_ir/expected/basic_8.js View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/cps_ir/expected/constructor_10.js View 1 2 chunks +11 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/cps_ir/expected/constructor_14.js View 1 1 chunk +0 lines, -1 line 0 comments Download
M tests/compiler/dart2js/cps_ir/expected/constructor_9.js View 1 2 chunks +2 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/cps_ir/input/constructor_10.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
M tests/compiler/dart2js/cps_ir/input/constructor_9.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/language_dart2js.status View 1 1 chunk +0 lines, -1 line 0 comments Download
M tests/lib/lib.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
asgerf
4 years, 11 months ago (2016-01-12 23:35:42 UTC) #2 
This is causing serious regression for some benchmark. I'm not sure if we should
tweak the inlining heuristics in the same CL.

Powered by Google App Engine
This is Rietveld 408576698