pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart - Issue 1584543002: dart2js cps: Support inlining constructors with type arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart

Issue 1584543002: dart2js cps: Support inlining constructors with type arguments. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Update status files and unit tests Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart

diff --git a/pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart b/pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart

index 979647ac22a0f79b822200bba8dac7af5b0dfd3e..2e3303ec68f6fae63cb48a9fcb932f59d0e0855c 100644

--- a/pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart

+++ b/pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart

@@ -516,9 +516,9 @@ class SubexpressionVisitor extends ExpressionVisitor<String> {

}

String visitCreateInstance(CreateInstance node) {

- String className = node.classElement.name;

+ String name = '${node.dartType}';

String arguments = node.arguments.map(visitExpression).join(', ');

- return 'CreateInstance $className($arguments)';

+ return 'CreateInstance $name($arguments)';

}

@override

« no previous file with comments | « pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart ('k') | tests/co19/co19-dart2js.status » ('j') | no next file with comments »