Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/object.cc

Issue 1584443002: VM: Precompiled rodata snapshot. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: compute string hash if necessary Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.h ('k') | runtime/vm/pages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.cc
diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc
index 97e721cdd31211f4566f7062a397881024ab1421..7824a5f33000bf13addbd4d35caaae75e54e4dad 100644
--- a/runtime/vm/object.cc
+++ b/runtime/vm/object.cc
@@ -912,9 +912,12 @@ class PremarkingVisitor : public ObjectVisitor {
if (!obj->IsFreeListElement()) {
ASSERT(obj->IsVMHeapObject());
if (obj->IsMarked()) {
- // Precompiled instructions are loaded pre-marked.
+ // Precompiled objects are loaded pre-marked.
ASSERT(Dart::IsRunningPrecompiledCode());
- ASSERT(obj->IsInstructions());
+ ASSERT(obj->IsInstructions() ||
+ obj->IsPcDescriptors() ||
+ obj->IsStackmap() ||
+ obj->IsOneByteString());
} else {
obj->SetMarkBitUnsynchronized();
}
« no previous file with comments | « runtime/vm/object.h ('k') | runtime/vm/pages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698