Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Unified Diff: runtime/vm/pages.h

Issue 1584443002: VM: Precompiled rodata snapshot. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: compute string hash if necessary Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/pages.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/pages.h
diff --git a/runtime/vm/pages.h b/runtime/vm/pages.h
index 17d1674d69c48d5c40eb13ad368b0ca810753975..008b7cdc29ba58dad1dcf969f850dd75ccf59860 100644
--- a/runtime/vm/pages.h
+++ b/runtime/vm/pages.h
@@ -31,6 +31,7 @@ class HeapPage {
enum PageType {
kData = 0,
kExecutable,
+ kReadOnlyData,
kNumPageTypes
};
@@ -49,7 +50,7 @@ class HeapPage {
}
PageType type() const {
- return executable_ ? kExecutable : kData;
+ return type_;
}
void VisitObjects(ObjectVisitor* visitor) const;
@@ -80,7 +81,7 @@ class HeapPage {
VirtualMemory* memory_;
HeapPage* next_;
uword object_end_;
- bool executable_;
+ PageType type_;
friend class PageSpace;
@@ -346,7 +347,7 @@ class PageSpace {
static intptr_t top_offset() { return OFFSET_OF(PageSpace, bump_top_); }
static intptr_t end_offset() { return OFFSET_OF(PageSpace, bump_end_); }
- void SetupInstructionsSnapshotPage(void* pointer, uword size);
+ void SetupExternalPage(void* pointer, uword size, bool is_executable);
private:
// Ids for time and data records in Heap::GCStats.
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/pages.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698