Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1584443002: VM: Precompiled rodata snapshot. (Closed)

Created:
4 years, 11 months ago by Florian Schneider
Modified:
4 years, 10 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Precompiled rodata snapshot. For now only contains PC descriptors and stack maps and one-byte strings. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/1f7458ddf816bb185f01c1697547fad5f630806d

Patch Set 1 #

Patch Set 2 : added stackmaps, setup heap pages for data snapshot #

Patch Set 3 : fixed header size, assertions, remove dead code #

Patch Set 4 : win32, android build #

Total comments: 6

Patch Set 5 : addressed comments, added OneByteString #

Patch Set 6 : change MacOs rodata section to .const #

Patch Set 7 : add -nostartfiles to make Linux work #

Patch Set 8 : rebased #

Patch Set 9 : align to page #

Patch Set 10 : added read-only page type #

Total comments: 2

Patch Set 11 : compute string hash if necessary #

Unified diffs Side-by-side diffs Delta from patch set Stats (+296 lines, -85 lines) Patch
M runtime/bin/extensions_android.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M runtime/bin/extensions_linux.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/bin/extensions_macos.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M runtime/bin/extensions_win.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M runtime/bin/gen_snapshot.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/main.cc View 1 2 3 4 5 6 7 8 9 10 3 chunks +10 lines, -3 lines 0 comments Download
M runtime/bin/run_vm_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/include/dart_api.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/dart.h View 1 2 3 4 5 6 7 8 9 10 3 chunks +9 lines, -0 lines 0 comments Download
M runtime/vm/dart.cc View 1 2 3 4 5 6 7 8 9 10 5 chunks +6 lines, -0 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/heap.h View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/isolate.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/isolate.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +20 lines, -2 lines 0 comments Download
M runtime/vm/object.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +5 lines, -2 lines 0 comments Download
M runtime/vm/pages.h View 1 2 3 4 5 6 7 8 9 4 chunks +4 lines, -3 lines 0 comments Download
M runtime/vm/pages.cc View 1 2 3 4 5 6 7 8 9 5 chunks +24 lines, -12 lines 0 comments Download
M runtime/vm/raw_object.h View 1 2 3 4 5 6 7 1 chunk +9 lines, -0 lines 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 1 2 3 4 5 6 7 8 9 10 9 chunks +39 lines, -39 lines 0 comments Download
M runtime/vm/snapshot.h View 1 2 3 4 5 6 7 8 10 chunks +67 lines, -6 lines 0 comments Download
M runtime/vm/snapshot.cc View 1 2 3 4 5 6 7 8 11 chunks +78 lines, -3 lines 0 comments Download
M runtime/vm/virtual_memory.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/virtual_memory.cc View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M tests/standalone/precompilation_dart2js_test.dart View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/precompilation_test.dart View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M tools/precompilation/test_linux.sh View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M tools/precompilation/test_linux_simarm.sh View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M tools/precompilation/test_macos.sh View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
Florian Schneider
4 years, 11 months ago (2016-01-14 19:30:12 UTC) #3
rmacnak
https://codereview.chromium.org/1584443002/diff/60001/runtime/vm/heap.h File runtime/vm/heap.h (right): https://codereview.chromium.org/1584443002/diff/60001/runtime/vm/heap.h#newcode254 runtime/vm/heap.h:254: void SetupInstructionsSnapshotPage(void* pointer, SetupExternalPage https://codereview.chromium.org/1584443002/diff/60001/runtime/vm/pages.cc File runtime/vm/pages.cc (right): https://codereview.chromium.org/1584443002/diff/60001/runtime/vm/pages.cc#newcode1075 ...
4 years, 11 months ago (2016-01-15 00:57:01 UTC) #4
Florian Schneider
addressed comments https://codereview.chromium.org/1584443002/diff/60001/runtime/vm/heap.h File runtime/vm/heap.h (right): https://codereview.chromium.org/1584443002/diff/60001/runtime/vm/heap.h#newcode254 runtime/vm/heap.h:254: void SetupInstructionsSnapshotPage(void* pointer, On 2016/01/15 00:57:01, rmacnak ...
4 years, 11 months ago (2016-01-15 15:56:01 UTC) #5
Florian Schneider
Added OneByteStrings. Fixed Mac section directive: ELF .rodata is the same as .const on Mach-O: ...
4 years, 11 months ago (2016-01-15 18:35:02 UTC) #6
Florian Schneider
Added -nostartfiles to linker command: Not needed for the precompiled binary, makes Linux work where ...
4 years, 11 months ago (2016-01-19 20:22:59 UTC) #7
Florian Schneider
ptal +vegorov
4 years, 10 months ago (2016-02-12 13:13:21 UTC) #10
rmacnak
lgtm w/c https://codereview.chromium.org/1584443002/diff/180001/runtime/vm/raw_object_snapshot.cc File runtime/vm/raw_object_snapshot.cc (right): https://codereview.chromium.org/1584443002/diff/180001/runtime/vm/raw_object_snapshot.cc#newcode2667 runtime/vm/raw_object_snapshot.cc:2667: ASSERT(writer->snapshot_code()); Assert the string's hash is calculated ...
4 years, 10 months ago (2016-02-12 17:59:45 UTC) #11
Florian Schneider
https://codereview.chromium.org/1584443002/diff/180001/runtime/vm/raw_object_snapshot.cc File runtime/vm/raw_object_snapshot.cc (right): https://codereview.chromium.org/1584443002/diff/180001/runtime/vm/raw_object_snapshot.cc#newcode2667 runtime/vm/raw_object_snapshot.cc:2667: ASSERT(writer->snapshot_code()); On 2016/02/12 17:59:45, rmacnak wrote: > Assert the ...
4 years, 10 months ago (2016-02-15 08:14:12 UTC) #12
Florian Schneider
4 years, 10 months ago (2016-02-15 08:15:33 UTC) #14
Message was sent while issue was closed. 
Committed patchset #11 (id:200001) manually as
1f7458ddf816bb185f01c1697547fad5f630806d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698