Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1584313005: Downplay the distinction between linked and prelinked summaries. (Closed)

Created:
4 years, 11 months ago by Paul Berry
Modified:
4 years, 11 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Downplay the distinction between linked and prelinked summaries. Following a discussion on Tuesday, we've decided to only deal with the distinction between linked and unlinked information in the summary definition for now. This should allow fully-linked information (such as constant evaluation, propagated types, and inferred types) to be added to summaries without much trouble. The distinction is preserved in the prelinker (which can't currently handle fully-linked information), and to some degree it will be preserved in unit tests (to minimize future churn). R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/a07b997e63249d90a3e56f90ddfbe8eea04a29f1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+502 lines, -519 lines) Patch
M pkg/analyzer/lib/src/summary/format.dart View 49 chunks +153 lines, -153 lines 0 comments Download
M pkg/analyzer/lib/src/summary/prelink.dart View 13 chunks +40 lines, -43 lines 0 comments Download
M pkg/analyzer/lib/src/summary/public_namespace_computer.dart View 4 chunks +9 lines, -11 lines 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 18 chunks +36 lines, -38 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 23 chunks +57 lines, -59 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summary_sdk.dart View 3 chunks +7 lines, -7 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 2 chunks +10 lines, -9 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_sdk_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_test.dart View 49 chunks +131 lines, -142 lines 0 comments Download
M pkg/analyzer/tool/summary/build_sdk_summary.dart View 3 chunks +6 lines, -7 lines 0 comments Download
M pkg/analyzer/tool/summary/idl.dart View 10 chunks +49 lines, -46 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
In theory there should be no functionality change. This CL is all renames.
4 years, 11 months ago (2016-01-15 00:25:58 UTC) #2
scheglov
LGTM
4 years, 11 months ago (2016-01-15 00:40:23 UTC) #3
Paul Berry
4 years, 11 months ago (2016-01-15 00:58:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a07b997e63249d90a3e56f90ddfbe8eea04a29f1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698