Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: pkg/analyzer/lib/src/summary/public_namespace_computer.dart

Issue 1584313005: Downplay the distinction between linked and prelinked summaries. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/summary/prelink.dart ('k') | pkg/analyzer/lib/src/summary/resynthesize.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/summary/public_namespace_computer.dart
diff --git a/pkg/analyzer/lib/src/summary/public_namespace_computer.dart b/pkg/analyzer/lib/src/summary/public_namespace_computer.dart
index 6de2ec848d8c612ba7f61ef1f72a045acc164825..7738b50687b8f093f3ceb843a941c78b861b3ba2 100644
--- a/pkg/analyzer/lib/src/summary/public_namespace_computer.dart
+++ b/pkg/analyzer/lib/src/summary/public_namespace_computer.dart
@@ -43,8 +43,7 @@ class _PublicNamespaceVisitor extends RecursiveAstVisitor {
_PublicNamespaceVisitor();
- void addNameIfPublic(
- String name, PrelinkedReferenceKind kind, int numTypeParameters) {
+ void addNameIfPublic(String name, ReferenceKind kind, int numTypeParameters) {
if (isPublic(name)) {
names.add(new UnlinkedPublicNameBuilder(
name: name, kind: kind, numTypeParameters: numTypeParameters));
@@ -55,19 +54,19 @@ class _PublicNamespaceVisitor extends RecursiveAstVisitor {
@override
visitClassDeclaration(ClassDeclaration node) {
- addNameIfPublic(node.name.name, PrelinkedReferenceKind.classOrEnum,
+ addNameIfPublic(node.name.name, ReferenceKind.classOrEnum,
node.typeParameters?.typeParameters?.length ?? 0);
}
@override
visitClassTypeAlias(ClassTypeAlias node) {
- addNameIfPublic(node.name.name, PrelinkedReferenceKind.classOrEnum,
+ addNameIfPublic(node.name.name, ReferenceKind.classOrEnum,
node.typeParameters?.typeParameters?.length ?? 0);
}
@override
visitEnumDeclaration(EnumDeclaration node) {
- addNameIfPublic(node.name.name, PrelinkedReferenceKind.classOrEnum, 0);
+ addNameIfPublic(node.name.name, ReferenceKind.classOrEnum, 0);
}
@override
@@ -88,14 +87,14 @@ class _PublicNamespaceVisitor extends RecursiveAstVisitor {
addNameIfPublic(
name,
node.isGetter || node.isSetter
- ? PrelinkedReferenceKind.topLevelPropertyAccessor
- : PrelinkedReferenceKind.topLevelFunction,
+ ? ReferenceKind.topLevelPropertyAccessor
+ : ReferenceKind.topLevelFunction,
node.functionExpression.typeParameters?.typeParameters?.length ?? 0);
}
@override
visitFunctionTypeAlias(FunctionTypeAlias node) {
- addNameIfPublic(node.name.name, PrelinkedReferenceKind.typedef,
+ addNameIfPublic(node.name.name, ReferenceKind.typedef,
node.typeParameters?.typeParameters?.length ?? 0);
}
@@ -107,10 +106,9 @@ class _PublicNamespaceVisitor extends RecursiveAstVisitor {
@override
visitVariableDeclaration(VariableDeclaration node) {
String name = node.name.name;
- addNameIfPublic(name, PrelinkedReferenceKind.topLevelPropertyAccessor, 0);
+ addNameIfPublic(name, ReferenceKind.topLevelPropertyAccessor, 0);
if (!node.isFinal && !node.isConst) {
- addNameIfPublic(
- '$name=', PrelinkedReferenceKind.topLevelPropertyAccessor, 0);
+ addNameIfPublic('$name=', ReferenceKind.topLevelPropertyAccessor, 0);
}
}
}
« no previous file with comments | « pkg/analyzer/lib/src/summary/prelink.dart ('k') | pkg/analyzer/lib/src/summary/resynthesize.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698