Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1584173003: Use getSourceReport for coverage/callsites in Observatory. (Closed)

Created:
4 years, 11 months ago by turnidge
Modified:
4 years, 11 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use getSourceReport for coverage/callsites in Observatory. Move script reloading into the script inset instead of the navbar. Make the refresh icon do a sticky-header scroll thing (fancy!). Remove old coverage code from observatory. BUG= Committed: https://github.com/dart-lang/sdk/commit/f23610b3e38db84a863e36bc3be8b2b57d5f1647

Patch Set 1 #

Patch Set 2 : cleanups #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+242 lines, -164 lines) Patch
M runtime/observatory/lib/src/elements/class_view.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/elements/class_view.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/debugger.dart View 1 9 chunks +7 lines, -33 lines 2 comments Download
M runtime/observatory/lib/src/elements/debugger.html View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/function_view.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/elements/function_view.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/isolate_view.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/elements/isolate_view.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/library_view.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/elements/library_view.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/script_inset.dart View 1 12 chunks +152 lines, -11 lines 1 comment Download
M runtime/observatory/lib/src/elements/script_inset.html View 5 chunks +50 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/script_view.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/elements/script_view.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 11 chunks +28 lines, -77 lines 0 comments Download
M runtime/observatory/tests/service/caching_test.dart View 1 chunk +2 lines, -15 lines 0 comments Download
M runtime/observatory/tests/service/get_source_report_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/service.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
turnidge
4 years, 11 months ago (2016-01-14 18:27:41 UTC) #2
Cutch
LGTMwC https://codereview.chromium.org/1584173003/diff/20001/runtime/observatory/lib/src/elements/debugger.dart File runtime/observatory/lib/src/elements/debugger.dart (right): https://codereview.chromium.org/1584173003/diff/20001/runtime/observatory/lib/src/elements/debugger.dart#newcode1934 runtime/observatory/lib/src/elements/debugger.dart:1934: int navbarHeight = 40; This is also hard ...
4 years, 11 months ago (2016-01-14 21:37:40 UTC) #3
turnidge
Committed patchset #2 (id:20001) manually as f23610b3e38db84a863e36bc3be8b2b57d5f1647 (presubmit successful).
4 years, 11 months ago (2016-01-15 17:19:03 UTC) #5
turnidge
4 years, 11 months ago (2016-01-15 18:37:03 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1584173003/diff/20001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/debugger.dart (right):

https://codereview.chromium.org/1584173003/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/debugger.dart:1934: int navbarHeight = 40;
On 2016/01/14 21:37:40, Cutch wrote:
> This is also hard coded in script_inset.dart can you factor this into a common
> place?

Done.

Powered by Google App Engine
This is Rietveld 408576698