Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1675)

Unified Diff: runtime/observatory/tests/service/caching_test.dart

Issue 1584173003: Use getSourceReport for coverage/callsites in Observatory. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: cleanups Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/tests/service/caching_test.dart
diff --git a/runtime/observatory/tests/service/caching_test.dart b/runtime/observatory/tests/service/caching_test.dart
index 8a72447c146ed0e25c93f78fd798199de9595436..6194ba65f7e1f1a6eee96a46292cdf3241e81ee8 100644
--- a/runtime/observatory/tests/service/caching_test.dart
+++ b/runtime/observatory/tests/service/caching_test.dart
@@ -13,27 +13,14 @@ import 'package:observatory/service_io.dart';
import 'package:unittest/unittest.dart';
import 'test_helper.dart';
-script() {
- print("This executed");
-}
-
-hasSomeCoverageData(Script script) {
- for (var line in script.lines) {
- if (line.hits != null) return true;
- }
- return false;
-}
-
var tests = [
(Isolate isolate) async {
Library lib = await isolate.rootLibrary.load();
Script script = await lib.scripts.single.load();
- expect(hasSomeCoverageData(script), isFalse);
- Script script2 = await script.refreshCoverage();
+ Script script2 = await isolate.getObject(script.id);
expect(identical(script, script2), isTrue);
- expect(hasSomeCoverageData(script), isTrue);
},
];
-main(args) => runIsolateTests(args, tests, testeeBefore: script);
+main(args) => runIsolateTests(args, tests);

Powered by Google App Engine
This is Rietveld 408576698