Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8854)

Unified Diff: chrome/renderer/resources/extensions/extension_custom_bindings.js

Issue 15841013: Make miscellaneous_bindings and event_bindings Required as needed. Previously (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/extension_custom_bindings.js
diff --git a/chrome/renderer/resources/extensions/extension_custom_bindings.js b/chrome/renderer/resources/extensions/extension_custom_bindings.js
index 2fe27775a79f98576970a83ff187f17a03a0e742..5650a073a854a1d40af2d868288b48ab674e99c6 100644
--- a/chrome/renderer/resources/extensions/extension_custom_bindings.js
+++ b/chrome/renderer/resources/extensions/extension_custom_bindings.js
@@ -9,13 +9,11 @@ var binding = require('binding').Binding.create('extension');
var extensionNatives = requireNative('extension');
var forEach = require('utils').forEach;
var GetExtensionViews = extensionNatives.GetExtensionViews;
+var miscBindings = require('miscellaneous_bindings');
var runtimeNatives = requireNative('runtime');
var OpenChannelToExtension = runtimeNatives.OpenChannelToExtension;
var OpenChannelToNativeApp = runtimeNatives.OpenChannelToNativeApp;
-var chromeHidden = requireNative('chrome_hidden').GetChromeHidden();
var chrome = requireNative('chrome').GetChrome();
-var sendMessageUpdateArguments =
- require('miscellaneous_bindings').sendMessageUpdateArguments;
var inIncognitoContext = requireNative('process').InIncognitoContext();
var sendRequestIsDisabled = requireNative('process').IsSendRequestDisabled();
@@ -89,15 +87,15 @@ binding.registerCustomHook(function(bindingsAPI, extensionId) {
});
apiFunctions.setUpdateArgumentsPreValidate('sendRequest',
- sendMessageUpdateArguments.bind(null, 'sendRequest'));
+ miscBindings.sendMessageUpdateArguments.bind(null, 'sendRequest'));
apiFunctions.setHandleRequest('sendRequest',
function(targetId, request, responseCallback) {
if (sendRequestIsDisabled)
throw new Error(sendRequestIsDisabled);
var port = chrome.runtime.connect(targetId || extensionId,
- {name: chromeHidden.kRequestChannel});
- chromeHidden.Port.sendMessageImpl(port, request, responseCallback);
+ {name: miscBindings.kRequestChannel});
+ miscBindings.sendMessageImpl(port, request, responseCallback);
});
if (sendRequestIsDisabled) {

Powered by Google App Engine
This is Rietveld 408576698