Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5644)

Unified Diff: chrome/renderer/resources/extensions/context_menus_custom_bindings.js

Issue 15841013: Make miscellaneous_bindings and event_bindings Required as needed. Previously (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/context_menus_custom_bindings.js
diff --git a/chrome/renderer/resources/extensions/context_menus_custom_bindings.js b/chrome/renderer/resources/extensions/context_menus_custom_bindings.js
index 4b0a9363a39fdeb91b125e498e6accf3eaface00..aa5cb570456fd8aaac50a5809589c10eac685e7e 100644
--- a/chrome/renderer/resources/extensions/context_menus_custom_bindings.js
+++ b/chrome/renderer/resources/extensions/context_menus_custom_bindings.js
@@ -6,11 +6,10 @@
var binding = require('binding').Binding.create('contextMenus');
-var contextMenus = requireNative('context_menus');
-var GetNextContextMenuId = contextMenus.GetNextContextMenuId;
-var sendRequest = require('sendRequest').sendRequest;
-
var chromeHidden = requireNative('chrome_hidden').GetChromeHidden();
+var contextMenuNatives = requireNative('context_menus');
+var sendRequest = require('sendRequest').sendRequest;
+var Event = require('event_bindings').Event;
binding.registerCustomHook(function(bindingsAPI) {
var apiFunctions = bindingsAPI.apiFunctions;
@@ -19,7 +18,7 @@ binding.registerCustomHook(function(bindingsAPI) {
chromeHidden.contextMenus.generatedIdHandlers = {};
chromeHidden.contextMenus.stringIdHandlers = {};
var eventName = 'contextMenus';
- chromeHidden.contextMenus.event = new chrome.Event(eventName);
+ chromeHidden.contextMenus.event = new Event(eventName);
chromeHidden.contextMenus.getIdFromCreateProperties = function(prop) {
if (typeof(prop.id) !== 'undefined')
return prop.id;
@@ -48,7 +47,7 @@ binding.registerCustomHook(function(bindingsAPI) {
apiFunctions.setHandleRequest('create', function() {
var args = arguments;
- var id = GetNextContextMenuId();
+ var id = contextMenuNatives.GetNextContextMenuId();
args[0].generatedId = id;
var optArgs = {
customCallback: this.customCallback,

Powered by Google App Engine
This is Rietveld 408576698