fix SkGpuDevice::drawBitmapRect to always update clips

fix SkGpuDevice::drawBitmapRect to always update clips

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1584073007

Committed: https://skia.googlesource.com/skia/+/973ed24fcb58db36588a19c18ae56af8f8adbba3

[lsalzman1, 2016-01-14 20:23:16]

Description was changed from

==========
fix SkGpuDevice::drawBitmapRect to always update clips

BUG=skia:
==========

to

==========
fix SkGpuDevice::drawBitmapRect to always update clips

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[lsalzman1, 2016-01-14 20:23:48]

Description was changed from

==========
fix SkGpuDevice::drawBitmapRect to always update clips

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
fix SkGpuDevice::drawBitmapRect to always update clips

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[lsalzman1, 2016-01-14 20:23:48]

lsalzman@mozilla.com changed reviewers:
+ mtklein@google.com

[lsalzman1, 2016-01-14 20:26:26]

We noticed in Firefox that if you draw to an SkGpuDevice::drawBitmapRect with a
software SkBitmap, it hits a path that does not run through
SkGpuDevice::prepareDraw because CHECK_SHOULD_DRAW never gets called along this
path.

This regression was introduced by this change here:
https://skia.googlesource.com/skia/+/b1b019985bee2bcbf35c2fbb4281904d0d3465bb...

This patch fixes CHECK_SHOULD_DRAW to be called first like in the other
drawBitmap/drawSprite/etc. functions.

[lsalzman1, 2016-01-14 20:32:36]

It should also be noted we discovered this bug in Firefox here:
https://bugzilla.mozilla.org/show_bug.cgi?id=1238795

The apparent symptom was images not being clipped when drawn to a
GPU-accelerated canvas.

[mtklein, 2016-01-14 20:36:22]

mtklein@google.com changed reviewers:
+ bsalomon@google.com

[mtklein, 2016-01-14 20:36:22]

+Brian

[bsalomon, 2016-01-14 20:38:47]

lgtm, nice catch.

[lsalzman1, 2016-01-14 20:54:01]

The CQ bit was checked by lsalzman@mozilla.com

[commit-bot: I haz the power, 2016-01-14 20:54:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1584073007/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1584073007/1

[commit-bot: I haz the power, 2016-01-14 21:06:43]

Description was changed from

==========
fix SkGpuDevice::drawBitmapRect to always update clips

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
fix SkGpuDevice::drawBitmapRect to always update clips

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/973ed24fcb58db36588a19c18ae56af8f8adbba3
==========

[commit-bot: I haz the power, 2016-01-14 21:06:44]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/973ed24fcb58db36588a19c18ae56af8f8adbba3