Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 1583953005: Unsandboxed popups may also be navigated. (Closed)

Created:
4 years, 11 months ago by Mike West
Modified:
4 years, 11 months ago
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Unsandboxed popups may also be navigated. If a sandboxed frame has the 'allow-popups-to-escape-sandbox' flag, it ought to be allowed to navigate the context it opens. This patch fixes our implementation accordingly. BUG=577330 R=jochen@chromium.org Committed: https://crrev.com/70d21e22b12a75c4034051eb84a065bffd5be04d Cr-Commit-Position: refs/heads/master@{#369702}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/http/tests/security/sandbox-inherit-to-blank-document-unsandboxed-navigate.html View 1 chunk +38 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Frame.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mike West
Mind taking a look, Jochen?
4 years, 11 months ago (2016-01-14 08:58:17 UTC) #1
jochen (gone - plz use gerrit)
lgtm
4 years, 11 months ago (2016-01-14 14:05:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1583953005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1583953005/1
4 years, 11 months ago (2016-01-15 08:26:14 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-15 08:57:32 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-15 08:59:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/70d21e22b12a75c4034051eb84a065bffd5be04d
Cr-Commit-Position: refs/heads/master@{#369702}

Powered by Google App Engine
This is Rietveld 408576698