Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1583933006: V8 Buildbot: Let leak checker use the v8-side wrapper. (Closed)

Created:
4 years, 11 months ago by Michael Achenbach
Modified:
4 years, 11 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

V8 Buildbot: Let leak checker use the v8-side wrapper. This will use valgrind binaries from third_party instead of an installed version, to make the bot more portable. Control about pass/fail of the check is now in the v8-side script which returns proper error codes. This also switches the bot from 32 bit to 64. Based on: https://codereview.chromium.org/1585093002/ BUG=535160 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298274

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -349 lines) Patch
M masters/master.client.v8/master.cfg View 1 2 chunks +3 lines, -3 lines 0 comments Download
M masters/master.client.v8/slaves.cfg View 1 2 chunks +4 lines, -4 lines 0 comments Download
M scripts/slave/recipe_modules/v8/builders.py View 1 3 chunks +6 lines, -5 lines 0 comments Download
M scripts/slave/recipe_modules/v8/gclient_config.py View 1 chunk +6 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/v8/test_api.py View 1 chunk +0 lines, -7 lines 0 comments Download
M scripts/slave/recipe_modules/v8/testing.py View 1 2 1 chunk +4 lines, -11 lines 0 comments Download
M scripts/slave/recipes/v8.py View 1 chunk +0 lines, -12 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___debug_builder.json View 1 1 chunk +19 lines, -1 line 0 comments Download
A + scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___memcheck.json View 1 4 chunks +9 lines, -15 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___debug_builder.json View 1 2 chunks +1 line, -20 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___memcheck.json View 1 1 chunk +0 lines, -136 lines 0 comments Download
D scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___memcheck_no_errors.json View 1 chunk +0 lines, -135 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Michael Achenbach
PTAL
4 years, 11 months ago (2016-01-14 11:37:03 UTC) #4
tandrii(chromium)
lgtm
4 years, 11 months ago (2016-01-14 13:23:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1583933006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1583933006/40001
4 years, 11 months ago (2016-01-14 18:59:19 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 19:02:45 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298274

Powered by Google App Engine
This is Rietveld 408576698