Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: scripts/slave/recipe_modules/v8/builders.py

Issue 1583933006: V8 Buildbot: Let leak checker use the v8-side wrapper. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Rebase Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « masters/master.client.v8/slaves.cfg ('k') | scripts/slave/recipe_modules/v8/gclient_config.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/v8/builders.py
diff --git a/scripts/slave/recipe_modules/v8/builders.py b/scripts/slave/recipe_modules/v8/builders.py
index 250ec6efd0e750925914416c3de493f1b4dabca0..323b1558d0bdcfd66cdb6bcc7ea1aa26ce07d0d0 100644
--- a/scripts/slave/recipe_modules/v8/builders.py
+++ b/scripts/slave/recipe_modules/v8/builders.py
@@ -93,7 +93,6 @@ BUILDERS = {
'V8 Linux - debug - isolates',
'V8 Linux - debug - nosse3',
'V8 Linux - debug - nosse4',
- 'V8 Linux - memcheck',
'V8 Linux - debug - greedy allocator',
],
},
@@ -437,6 +436,7 @@ BUILDERS = {
'V8 Linux64 - debug',
'V8 Linux64 - debug - avx2',
'V8 Linux64 - debug - greedy allocator',
+ 'V8 Linux64 - memcheck',
],
},
'V8 Linux64 - custom snapshot - debug builder': {
@@ -1408,14 +1408,15 @@ BUILDERS = {
],
'testing': {'platform': 'linux'},
},
- 'V8 Linux - memcheck': {
+ 'V8 Linux64 - memcheck': {
+ 'gclient_apply_config': ['v8_valgrind'],
'v8_config_kwargs': {
'BUILD_CONFIG': 'Debug',
- 'TARGET_BITS': 32,
+ 'TARGET_BITS': 64,
},
'bot_type': 'tester',
- 'parent_buildername': 'V8 Linux - debug builder',
- 'build_gs_archive': 'linux_dbg_archive',
+ 'parent_buildername': 'V8 Linux64 - debug builder',
+ 'build_gs_archive': 'linux64_dbg_archive',
'tests': [SimpleLeak],
'testing': {'platform': 'linux'},
},
« no previous file with comments | « masters/master.client.v8/slaves.cfg ('k') | scripts/slave/recipe_modules/v8/gclient_config.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698