Update network error interstitial strings

Update network error interstitial strings
+ Updated headings
+ Updated summary paragraph and moved from under details to below the heading.

Reference UI review deck is in the bug description. Implementation screenshots https://code.google.com/p/chromium/issues/detail?id=518975#c8
---
Fixes a bug in the heading in the original CL 1500993002

BUG=518975
Committed: https://crrev.com/e9d69a39c426080cbe4e9891dbe65110f983e307
Cr-Commit-Position: refs/heads/master@{#369571}

[edwardjung, 2016-01-14 01:05:52]

edwardjung@chromium.org changed reviewers:
+ jochen@chromium.org, mmenke@chromium.org

[edwardjung, 2016-01-14 01:05:52]

Mmenke, please take a look again. 

Unfortunately the previous CL had a bug with the heading string changes with the
host name string substitution. 

Differences in this CL from the previous one: 
+ error_page_strings.grdp : Made a change to all the headings that display the
host name to use do the population via the JS template rather than use
l10n_util::GetStringFUTF16() 

Also switched to using a span as a wrapper for the host name rather than strong
tag. Will style via CSS using a less heavy font weight.

+ localized_error.cc : Corresponding code changes for the above.

+ neterror.html : Removed the jsselect attribute from h1 heading. 
 
Thanks.

[jochen (gone - plz use gerrit), 2016-01-14 14:12:29]

lgtm once mmenke is happy

[blundell, 2016-01-14 15:58:00]

Description was changed from

==========
Update network error interstitial strings
+ Updated headings
+ Updated summary paragraph and moved from under details to below the heading.

Reference UI review deck is in the bug description. Implementation screenshots
https://code.google.com/p/chromium/issues/detail?id=518975#c8
---
Fixes a bug in the heading in the original CL 1500993002

BUG=518975
==========

to

==========
Update network error interstitial strings
+ Updated headings
+ Updated summary paragraph and moved from under details to below the heading.

Reference UI review deck is in the bug description. Implementation screenshots
https://code.google.com/p/chromium/issues/detail?id=518975#c8
---
Fixes a bug in the heading in the original CL 1500993002

BUG=518975
==========

[mmenke, 2016-01-14 16:38:19]

On 2016/01/14 14:12:29, jochen wrote:
> lgtm once mmenke is happy

Could you upload the original CL as well, so I can see exactly what the
differences are?

[edwardjung, 2016-01-14 17:09:54]

On 2016/01/14 16:38:19, mmenke wrote:
> On 2016/01/14 14:12:29, jochen wrote:
> > lgtm once mmenke is happy
> 
> Could you upload the original CL as well, so I can see exactly what the
> differences are?

Sorry, should have done that originally. Diff between patch set 2 and 3.

[mmenke, 2016-01-14 17:35:54]

https://codereview.chromium.org/1583693005/diff/40001/components/error_page_s...
File components/error_page_strings.grdp (right):

https://codereview.chromium.org/1583693005/diff/40001/components/error_page_s...
components/error_page_strings.grdp:166: This <ph name="HOST_NAME">&lt;span
jsselect="summary"
jscontent="hostName"&gt;&lt;/span&gt;<ex>www.whatever.com</ex></ph> page can’t
be found
Having the heading reach into data for the summary string below it to get
hostName seems weird.  Maybe just copy how summary works?  i.e.:

<p jsselect="heading" jsvalues=".innerHTML:msg"></p>

And then make the heading a dictionary, with a hostName field?  Alternatively,
make hostName a top level variable, and get rid of the jscontent here (And then
modify summary to do the same)

[edwardjung, 2016-01-14 18:19:21]

https://codereview.chromium.org/1583693005/diff/40001/components/error_page_s...
File components/error_page_strings.grdp (right):

https://codereview.chromium.org/1583693005/diff/40001/components/error_page_s...
components/error_page_strings.grdp:166: This <ph name="HOST_NAME">&lt;span
jsselect="summary"
jscontent="hostName"&gt;&lt;/span&gt;<ex>www.whatever.com</ex></ph> page can’t
be found
On 2016/01/14 17:35:54, mmenke wrote:
> Having the heading reach into data for the summary string below it to get
> hostName seems weird.  Maybe just copy how summary works?  i.e.:
> 
> <p jsselect="heading" jsvalues=".innerHTML:msg"></p>
> 
> And then make the heading a dictionary, with a hostName field?  Alternatively,
> make hostName a top level variable, and get rid of the jscontent here (And
then
> modify summary to do the same)

Makes sense. I've created a new dictionary for heading.

[mmenke, 2016-01-14 18:20:34]

LGTM

[edwardjung, 2016-01-14 19:14:48]

The CQ bit was checked by edwardjung@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-14 19:15:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1583693005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1583693005/60001

[commit-bot: I haz the power, 2016-01-14 20:37:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-14 20:37:50]

Dry run: This issue passed the CQ dry run.

[edwardjung, 2016-01-14 22:06:15]

The CQ bit was checked by edwardjung@chromium.org

[edwardjung, 2016-01-14 22:06:15]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1583693005/#ps60001
(title: "Add heading dictionary")

[commit-bot: I haz the power, 2016-01-14 22:08:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1583693005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1583693005/60001

[commit-bot: I haz the power, 2016-01-14 22:15:21]

Description was changed from

==========
Update network error interstitial strings
+ Updated headings
+ Updated summary paragraph and moved from under details to below the heading.

Reference UI review deck is in the bug description. Implementation screenshots
https://code.google.com/p/chromium/issues/detail?id=518975#c8
---
Fixes a bug in the heading in the original CL 1500993002

BUG=518975
==========

to

==========
Update network error interstitial strings
+ Updated headings
+ Updated summary paragraph and moved from under details to below the heading.

Reference UI review deck is in the bug description. Implementation screenshots
https://code.google.com/p/chromium/issues/detail?id=518975#c8
---
Fixes a bug in the heading in the original CL 1500993002

BUG=518975
==========

[commit-bot: I haz the power, 2016-01-14 22:15:21]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-01-14 22:17:01]

Description was changed from

==========
Update network error interstitial strings
+ Updated headings
+ Updated summary paragraph and moved from under details to below the heading.

Reference UI review deck is in the bug description. Implementation screenshots
https://code.google.com/p/chromium/issues/detail?id=518975#c8
---
Fixes a bug in the heading in the original CL 1500993002

BUG=518975
==========

to

==========
Update network error interstitial strings
+ Updated headings
+ Updated summary paragraph and moved from under details to below the heading.

Reference UI review deck is in the bug description. Implementation screenshots
https://code.google.com/p/chromium/issues/detail?id=518975#c8
---
Fixes a bug in the heading in the original CL 1500993002

BUG=518975

Committed: https://crrev.com/e9d69a39c426080cbe4e9891dbe65110f983e307
Cr-Commit-Position: refs/heads/master@{#369571}
==========

[commit-bot: I haz the power, 2016-01-14 22:17:01]

Patchset 4 (id:??) landed as
https://crrev.com/e9d69a39c426080cbe4e9891dbe65110f983e307
Cr-Commit-Position: refs/heads/master@{#369571}