cc/scheduler/scheduler_state_machine.cc - Issue 15836005: cc: Emulate BeginFrame in OutputSurfaces that don't support it natively

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/scheduler/scheduler_state_machine.cc

Issue 15836005: cc: Emulate BeginFrame in OutputSurfaces that don't support it natively (Closed) Base URL: http://git.chromium.org/chromium/src.git@nofrc

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/scheduler/scheduler_state_machine.cc

diff --git a/cc/scheduler/scheduler_state_machine.cc b/cc/scheduler/scheduler_state_machine.cc

index 01252dd7aff1c21a0330eb5c9598a567658a6eb1..c065e26c04762f3feefce1517a2144c916f3f03b 100644

--- a/cc/scheduler/scheduler_state_machine.cc

+++ b/cc/scheduler/scheduler_state_machine.cc

@@ -332,6 +332,10 @@ void SchedulerStateMachine::SetMainThreadNeedsLayerTextures() {

}

bool SchedulerStateMachine::BeginFrameNeededByImplThread() const {

+ // We should proactively request a BeginFrame if a commit is pending.

brianderson 2013/06/01 04:30:29 I would get hangs without this.

+ if (commit_state_ != COMMIT_STATE_IDLE)

+ return true;

// If we have a pending tree, need to keep getting notifications until

// the tree is ready to be swapped.

if (has_pending_tree_)

« cc/scheduler/scheduler.cc ('K') | « cc/scheduler/scheduler_state_machine.h ('k') | cc/scheduler/scheduler_unittest.cc » ('j') | cc/trees/thread_proxy.cc » ('J')