Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(738)

Issue 1583583003: bluetooth: android: Implement characteristic GetService. (Closed)

Created:
4 years, 11 months ago by scheib
Modified:
4 years, 11 months ago
Reviewers:
Jeffrey Yasskin
CC:
chromium-reviews, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@bta-descriptors-
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: android: Implement characteristic GetService. Required for upcoming patch https://codereview.chromium.org/1502833002/ using TestBluetoothAdapterObserver::GattCharacteristicValueChanged which verifies GetService. BUG=545682 Committed: https://crrev.com/346fea951d1cec1bd49d4afca19ec9fc0a6b8124 Cr-Commit-Position: refs/heads/master@{#369082}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -12 lines) Patch
M device/bluetooth/bluetooth_gatt_characteristic_unittest.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_characteristic_android.h View 3 chunks +9 lines, -4 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_characteristic_android.cc View 3 chunks +9 lines, -6 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_service_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 9 (5 generated)
Jeffrey Yasskin
lgtm
4 years, 11 months ago (2016-01-13 01:05:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1583583003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1583583003/1
4 years, 11 months ago (2016-01-13 01:11:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-13 02:28:49 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-13 02:30:20 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/346fea951d1cec1bd49d4afca19ec9fc0a6b8124
Cr-Commit-Position: refs/heads/master@{#369082}

Powered by Google App Engine
This is Rietveld 408576698