Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 1577623002: bluetooth: android: Implement Descriptor Write as needed for notifications. (Closed)

Created:
4 years, 11 months ago by scheib
Modified:
4 years, 11 months ago
Reviewers:
Jeffrey Yasskin
CC:
chromium-reviews, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@bta-descriptors-
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: android: Implement Descriptor Write as needed for notifications. Implements the ability to write to descriptor values in preparation for [following patch] that will use descriptors for enabling notifications. Testing is deferred to [following patch], as this code isn't exposed to public API until that patch. [following patch] https://codereview.chromium.org/1502833002/ BUG=566533 Committed: https://crrev.com/98cb300cb67c773598bd01184b0ffce8537004b1 Cr-Commit-Position: refs/heads/master@{#369105}

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -2 lines) Patch
M device/bluetooth/android/java/src/org/chromium/device/bluetooth/Wrappers.java View 2 chunks +12 lines, -0 lines 0 comments Download
M device/bluetooth/test/android/java/src/org/chromium/device/bluetooth/Fakes.java View 6 chunks +46 lines, -2 lines 2 comments Download
M device/bluetooth/test/bluetooth_test.h View 2 chunks +6 lines, -0 lines 0 comments Download
M device/bluetooth/test/bluetooth_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M device/bluetooth/test/bluetooth_test_android.h View 2 chunks +8 lines, -0 lines 0 comments Download
M device/bluetooth/test/bluetooth_test_android.cc View 2 chunks +17 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
Jeffrey Yasskin
lgtm https://codereview.chromium.org/1577623002/diff/40001/device/bluetooth/test/android/java/src/org/chromium/device/bluetooth/Fakes.java File device/bluetooth/test/android/java/src/org/chromium/device/bluetooth/Fakes.java (right): https://codereview.chromium.org/1577623002/diff/40001/device/bluetooth/test/android/java/src/org/chromium/device/bluetooth/Fakes.java#newcode603 device/bluetooth/test/android/java/src/org/chromium/device/bluetooth/Fakes.java:603: // Cause subsequent value write of a descriptor ...
4 years, 11 months ago (2016-01-13 01:52:34 UTC) #6
scheib
https://codereview.chromium.org/1577623002/diff/40001/device/bluetooth/test/android/java/src/org/chromium/device/bluetooth/Fakes.java File device/bluetooth/test/android/java/src/org/chromium/device/bluetooth/Fakes.java (right): https://codereview.chromium.org/1577623002/diff/40001/device/bluetooth/test/android/java/src/org/chromium/device/bluetooth/Fakes.java#newcode603 device/bluetooth/test/android/java/src/org/chromium/device/bluetooth/Fakes.java:603: // Cause subsequent value write of a descriptor to ...
4 years, 11 months ago (2016-01-13 02:01:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1577623002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1577623002/40001
4 years, 11 months ago (2016-01-13 02:41:26 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 11 months ago (2016-01-13 03:52:25 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-13 03:53:40 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/98cb300cb67c773598bd01184b0ffce8537004b1
Cr-Commit-Position: refs/heads/master@{#369105}

Powered by Google App Engine
This is Rietveld 408576698