[css-align] New CSS Value 'normal' for Content Alignment

[css-align] New CSS Value 'normal' for Content Alignment

The Box Alignment specification defines a new value 'normal' to be used
as default for the different layout models, which will define the
specific behavior for each case. This patch adds a new CSS value in the
parsing logic and adapts the Content Alignment properties to the new
value.

The 'auto' value is no longer valid and the Computed Value will be
always the specified value. Hence, I removed the StyleResolver logic
because is not required now; the specific behavior of the 'normal'
value will be resolved at layout time.

Computed value of both align-content and justify-content is the
specified value, we don't have to resolve any 'auto' value now.

Additionally, this patch updates the layout logic as well, for both
Flexbox and Grid layout models.

BUG=565883
Committed: https://crrev.com/8e62cf6142a2e1d917eb64a7ead637bd020b39cc
Cr-Commit-Position: refs/heads/master@{#375556}

[jfernandez, 2016-01-12 11:36:53]

Description was changed from

==========
[css-align] New CSS Value 'normal' for Content Alignment

The Box Alignment specification defines a new value 'normal' to be used
as default for the different layout models, which will define the
specific behavior for each case.

This patch addes the new CSS value in the parsing logic and adapts the
Content Alignment propeties to the new value. The 'auto' value is no
longer valid.

Additinally, this patch updates the layout logic as well, for both
Flexbox and Grid layout models.

BUG=376823, 249451
==========

to

==========
[css-align] New CSS Value 'normal' for Content Alignment

The Box Alignment specification defines a new value 'normal' to be used
as default for the different layout models, which will define the
specific behavior for each case.

This patch adds a new CSS value in the parsing logic and adapts the
Content Alignment propeties to the new value. 

The 'auto' value is no longer valid and the Computed Value will be always the
specified value. Hence, I removed the StyleResolver logic because is not
required
now; the specific behavior of the 'normal' value will be resolved at layout
time.

Additionally, this patch updates the layout logic as well, for both
Flexbox and Grid layout models.

BUG=376823, 249451
==========

[jfernandez, 2016-01-12 11:37:31]

jfernandez@igalia.com changed reviewers:
+ cbiesinger@chromium.org, svillar@igalia.com, timloh@chromium.org

[jfernandez, 2016-01-12 11:38:25]

Description was changed from

==========
[css-align] New CSS Value 'normal' for Content Alignment

The Box Alignment specification defines a new value 'normal' to be used
as default for the different layout models, which will define the
specific behavior for each case.

This patch adds a new CSS value in the parsing logic and adapts the
Content Alignment propeties to the new value. 

The 'auto' value is no longer valid and the Computed Value will be always the
specified value. Hence, I removed the StyleResolver logic because is not
required
now; the specific behavior of the 'normal' value will be resolved at layout
time.

Additionally, this patch updates the layout logic as well, for both
Flexbox and Grid layout models.

BUG=376823, 249451
==========

to

==========
[css-align] New CSS Value 'normal' for Content Alignment

The Box Alignment specification defines a new value 'normal' to be used
as default for the different layout models, which will define the
specific behavior for each case.

This patch adds a new CSS value in the parsing logic and adapts the
Content Alignment propeties to the new value. 

The 'auto' value is no longer valid and the Computed Value will be 
always the specified value. Hence, I removed the StyleResolver logic 
because is not required now; the specific behavior of the 'normal' 
value will be resolved at layout time.

Additionally, this patch updates the layout logic as well, for both
Flexbox and Grid layout models.

BUG=376823, 249451
==========

[jfernandez, 2016-01-13 22:27:18]

Description was changed from

==========
[css-align] New CSS Value 'normal' for Content Alignment

The Box Alignment specification defines a new value 'normal' to be used
as default for the different layout models, which will define the
specific behavior for each case.

This patch adds a new CSS value in the parsing logic and adapts the
Content Alignment propeties to the new value. 

The 'auto' value is no longer valid and the Computed Value will be 
always the specified value. Hence, I removed the StyleResolver logic 
because is not required now; the specific behavior of the 'normal' 
value will be resolved at layout time.

Additionally, this patch updates the layout logic as well, for both
Flexbox and Grid layout models.

BUG=376823, 249451
==========

to

==========
[css-align] New CSS Value 'normal' for Content Alignment

The Box Alignment specification defines a new value 'normal' to be used
as default for the different layout models, which will define the
specific behavior for each case.

This patch adds a new CSS value in the parsing logic and adapts the
Content Alignment properties to the new value. 

The 'auto' value is no longer valid and the Computed Value will be 
always the specified value. Hence, I removed the StyleResolver logic 
because is not required now; the specific behavior of the 'normal' 
value will be resolved at layout time.

Additionally, this patch updates the layout logic as well, for both
Flexbox and Grid layout models.

BUG=376823, 249451
==========

[cbiesinger, 2016-01-14 06:38:12]

lgtm

[jfernandez, 2016-01-14 08:54:31]

Description was changed from

==========
[css-align] New CSS Value 'normal' for Content Alignment

The Box Alignment specification defines a new value 'normal' to be used
as default for the different layout models, which will define the
specific behavior for each case.

This patch adds a new CSS value in the parsing logic and adapts the
Content Alignment properties to the new value. 

The 'auto' value is no longer valid and the Computed Value will be 
always the specified value. Hence, I removed the StyleResolver logic 
because is not required now; the specific behavior of the 'normal' 
value will be resolved at layout time.

Additionally, this patch updates the layout logic as well, for both
Flexbox and Grid layout models.

BUG=376823, 249451
==========

to

==========
[css-align] New CSS Value 'normal' for Content Alignment

The Box Alignment specification defines a new value 'normal' to be used
as default for the different layout models, which will define the
specific behavior for each case. This patch adds a new CSS value in the 
parsing logic and adapts the Content Alignment properties to the new
value. 

The 'auto' value is no longer valid and the Computed Value will be 
always the specified value. Hence, I removed the StyleResolver logic 
because is not required now; the specific behavior of the 'normal' 
value will be resolved at layout time.

Computed value of both align-content and justify-content is the
specified value, we don't have to resolve any 'auto' value now.

Additionally, this patch updates the layout logic as well, for both
Flexbox and Grid layout models.

BUG=376823, 249451
==========

[Timothy Loh, 2016-01-15 04:35:09]

ok lgtm

[jfernandez, 2016-01-18 16:59:19]

Description was changed from

==========
[css-align] New CSS Value 'normal' for Content Alignment

The Box Alignment specification defines a new value 'normal' to be used
as default for the different layout models, which will define the
specific behavior for each case. This patch adds a new CSS value in the 
parsing logic and adapts the Content Alignment properties to the new
value. 

The 'auto' value is no longer valid and the Computed Value will be 
always the specified value. Hence, I removed the StyleResolver logic 
because is not required now; the specific behavior of the 'normal' 
value will be resolved at layout time.

Computed value of both align-content and justify-content is the
specified value, we don't have to resolve any 'auto' value now.

Additionally, this patch updates the layout logic as well, for both
Flexbox and Grid layout models.

BUG=376823, 249451
==========

to

==========
[css-align] New CSS Value 'normal' for Content Alignment

The Box Alignment specification defines a new value 'normal' to be used
as default for the different layout models, which will define the
specific behavior for each case. This patch adds a new CSS value in the 
parsing logic and adapts the Content Alignment properties to the new
value. 

The 'auto' value is no longer valid and the Computed Value will be 
always the specified value. Hence, I removed the StyleResolver logic 
because is not required now; the specific behavior of the 'normal' 
value will be resolved at layout time.

Computed value of both align-content and justify-content is the
specified value, we don't have to resolve any 'auto' value now.

Additionally, this patch updates the layout logic as well, for both
Flexbox and Grid layout models.

BUG=565883
==========

[Timothy Loh, 2016-02-01 00:27:46]

Any update here?

(BTW, you'll have to rebase over https://codereview.chromium.org/1523803002/
once that lands)

[jfernandez, 2016-02-01 08:59:13]

On 2016/02/01 00:27:46, Timothy Loh wrote:
> Any update here?
> 

I'm waiting for https://codereview.chromium.org/1625993004/ to land first.

> (BTW, you'll have to rebase over https://codereview.chromium.org/1523803002/
> once that lands)

Oh, sure.

[jfernandez, 2016-02-02 11:37:06]

The CQ bit was checked by jfernandez@igalia.com

[jfernandez, 2016-02-02 11:37:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
cbiesinger@chromium.org, timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/1583433002/#ps60001
(title: "Patch rebased.")

[commit-bot: I haz the power, 2016-02-02 11:38:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1583433002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1583433002/60001

[commit-bot: I haz the power, 2016-02-02 12:42:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-02 12:42:44]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jfernandez, 2016-02-05 09:40:55]

Now that 'normal' behaves like 'stretch', instead of 'start', for both content
alignment properties we need to rebaseline many tests. Since 'normal' is the
defailt/initial value, those tests that for simplicity don't set the content
alignment properties will have the tracks stretched.

[jfernandez, 2016-02-15 22:59:39]

@svillar could you review the changes in the tests ? I had to explicitly set
justify/align-content as 'start' to avoid the 'stretch' by default in lots of
tests.

[jfernandez, 2016-02-16 11:28:26]

The CQ bit was checked by jfernandez@igalia.com

[jfernandez, 2016-02-16 11:28:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
cbiesinger@chromium.org, timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/1583433002/#ps100001
(title: "Fixed layout tests failing.")

[commit-bot: I haz the power, 2016-02-16 11:28:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1583433002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1583433002/100001

[commit-bot: I haz the power, 2016-02-16 12:35:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-16 12:35:52]

Failed to request the patch to try. Please note that binary files are still
unsupported at the moment, this is being worked on.

Thanks for your patience.

Transient error: No JSON object could be decoded

[commit-bot: I haz the power, 2016-02-16 12:36:09]

The CQ bit was unchecked by commit-bot@chromium.org

[jfernandez, 2016-02-16 13:01:08]

The CQ bit was checked by jfernandez@igalia.com

[commit-bot: I haz the power, 2016-02-16 13:01:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1583433002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1583433002/100001

[commit-bot: I haz the power, 2016-02-16 13:11:55]

Description was changed from

==========
[css-align] New CSS Value 'normal' for Content Alignment

The Box Alignment specification defines a new value 'normal' to be used
as default for the different layout models, which will define the
specific behavior for each case. This patch adds a new CSS value in the 
parsing logic and adapts the Content Alignment properties to the new
value. 

The 'auto' value is no longer valid and the Computed Value will be 
always the specified value. Hence, I removed the StyleResolver logic 
because is not required now; the specific behavior of the 'normal' 
value will be resolved at layout time.

Computed value of both align-content and justify-content is the
specified value, we don't have to resolve any 'auto' value now.

Additionally, this patch updates the layout logic as well, for both
Flexbox and Grid layout models.

BUG=565883
==========

to

==========
[css-align] New CSS Value 'normal' for Content Alignment

The Box Alignment specification defines a new value 'normal' to be used
as default for the different layout models, which will define the
specific behavior for each case. This patch adds a new CSS value in the 
parsing logic and adapts the Content Alignment properties to the new
value. 

The 'auto' value is no longer valid and the Computed Value will be 
always the specified value. Hence, I removed the StyleResolver logic 
because is not required now; the specific behavior of the 'normal' 
value will be resolved at layout time.

Computed value of both align-content and justify-content is the
specified value, we don't have to resolve any 'auto' value now.

Additionally, this patch updates the layout logic as well, for both
Flexbox and Grid layout models.

BUG=565883
==========

[commit-bot: I haz the power, 2016-02-16 13:11:56]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-02-16 22:52:21]

Description was changed from

==========
[css-align] New CSS Value 'normal' for Content Alignment

The Box Alignment specification defines a new value 'normal' to be used
as default for the different layout models, which will define the
specific behavior for each case. This patch adds a new CSS value in the 
parsing logic and adapts the Content Alignment properties to the new
value. 

The 'auto' value is no longer valid and the Computed Value will be 
always the specified value. Hence, I removed the StyleResolver logic 
because is not required now; the specific behavior of the 'normal' 
value will be resolved at layout time.

Computed value of both align-content and justify-content is the
specified value, we don't have to resolve any 'auto' value now.

Additionally, this patch updates the layout logic as well, for both
Flexbox and Grid layout models.

BUG=565883
==========

to

==========
[css-align] New CSS Value 'normal' for Content Alignment

The Box Alignment specification defines a new value 'normal' to be used
as default for the different layout models, which will define the
specific behavior for each case. This patch adds a new CSS value in the
parsing logic and adapts the Content Alignment properties to the new
value.

The 'auto' value is no longer valid and the Computed Value will be
always the specified value. Hence, I removed the StyleResolver logic
because is not required now; the specific behavior of the 'normal'
value will be resolved at layout time.

Computed value of both align-content and justify-content is the
specified value, we don't have to resolve any 'auto' value now.

Additionally, this patch updates the layout logic as well, for both
Flexbox and Grid layout models.

BUG=565883

Committed: https://crrev.com/8e62cf6142a2e1d917eb64a7ead637bd020b39cc
Cr-Commit-Position: refs/heads/master@{#375556}
==========

[commit-bot: I haz the power, 2016-02-16 22:52:22]

Patchset 6 (id:??) landed as
https://crrev.com/8e62cf6142a2e1d917eb64a7ead637bd020b39cc
Cr-Commit-Position: refs/heads/master@{#375556}