Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/LayoutTests/fast/alignment/parse-justify-content.html

Issue 1583433002: [css-align] New CSS Value 'normal' for Content Alignment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed layout tests failing. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/alignment/parse-align-content-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/alignment/parse-justify-content-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/fast/alignment/parse-justify-content.html
diff --git a/third_party/WebKit/LayoutTests/fast/alignment/parse-justify-content.html b/third_party/WebKit/LayoutTests/fast/alignment/parse-justify-content.html
index 08ca3fdab0acd497f71d61fba6bd39ca1f3b78c8..ed0b00350ac3cc36d8ca35865d471621370c319a 100644
--- a/third_party/WebKit/LayoutTests/fast/alignment/parse-justify-content.html
+++ b/third_party/WebKit/LayoutTests/fast/alignment/parse-justify-content.html
@@ -169,7 +169,7 @@ description('Test that setting and getting justify-content works as expected');
debug("Test getting justify-content set through CSS");
var justifyContentAuto = document.getElementById("justifyContentAuto");
-shouldBeEqualToString("getComputedStyle(justifyContentAuto, '').getPropertyValue('justify-content')", "start");
+shouldBeEqualToString("getComputedStyle(justifyContentAuto, '').getPropertyValue('justify-content')", "normal");
var justifyContentBaseline = document.getElementById("justifyContentBaseline");
shouldBeEqualToString("getComputedStyle(justifyContentBaseline, '').getPropertyValue('justify-content')", "baseline");
@@ -247,25 +247,25 @@ var justifyContentSpaceEvenlyFlexStartSafe = document.getElementById("justifyCon
shouldBeEqualToString("getComputedStyle(justifyContentSpaceEvenlyFlexStartSafe, '').getPropertyValue('justify-content')", "space-evenly flex-start safe");
var justifyContentSpaceBetweenSafe = document.getElementById("justifyContentSpaceBetweenSafe");
-shouldBeEqualToString("getComputedStyle(justifyContentSpaceBetweenSafe, '').getPropertyValue('justify-content')", "start");
+shouldBeEqualToString("getComputedStyle(justifyContentSpaceBetweenSafe, '').getPropertyValue('justify-content')", "normal");
var justifyContentSpaceAroundUnsafe = document.getElementById("justifyContentSpaceBetweenStretch");
-shouldBeEqualToString("getComputedStyle(justifyContentSpaceBetweenStretch, '').getPropertyValue('justify-content')", "start");
+shouldBeEqualToString("getComputedStyle(justifyContentSpaceBetweenStretch, '').getPropertyValue('justify-content')", "normal");
var justifyContentSpaceAroundUnsafe = document.getElementById("justifyContentSafe");
-shouldBeEqualToString("getComputedStyle(justifyContentSafe, '').getPropertyValue('justify-content')", "start");
+shouldBeEqualToString("getComputedStyle(justifyContentSafe, '').getPropertyValue('justify-content')", "normal");
var justifyContentSpaceAroundUnsafe = document.getElementById("justifyContentRightSafeUnsafe");
-shouldBeEqualToString("getComputedStyle(justifyContentRightSafeUnsafe, '').getPropertyValue('justify-content')", "start");
+shouldBeEqualToString("getComputedStyle(justifyContentRightSafeUnsafe, '').getPropertyValue('justify-content')", "normal");
var justifyContentSpaceAroundUnsafe = document.getElementById("justifyContentCenterLeft");
-shouldBeEqualToString("getComputedStyle(justifyContentCenterLeft, '').getPropertyValue('justify-content')", "start");
+shouldBeEqualToString("getComputedStyle(justifyContentCenterLeft, '').getPropertyValue('justify-content')", "normal");
debug("");
debug("Test initial value of justify-content through JS");
element = document.createElement("div");
document.body.appendChild(element);
-shouldBeEqualToString("getComputedStyle(element, '').getPropertyValue('justify-content')", "start");
+shouldBeEqualToString("getComputedStyle(element, '').getPropertyValue('justify-content')", "normal");
debug("");
debug("Test getting and setting justify-content through JS");
@@ -289,16 +289,16 @@ checkValues(element, "justifyContent", "justify-content", "stretch center", "st
element.style.justifyContent = "right unsafe";
checkValues(element, "justifyContent", "justify-content", "right unsafe", "right unsafe");
-element.style.justifyContent = "auto";
-checkValues(element, "justifyContent", "justify-content", "auto", "start");
+element.style.justifyContent = "normal";
+checkValues(element, "justifyContent", "justify-content", "normal", "normal");
element.style.display = "flex";
-element.style.justifyContent = "auto";
-checkValues(element, "justifyContent", "justify-content", "auto", "flex-start");
+element.style.justifyContent = "normal";
+checkValues(element, "justifyContent", "justify-content", "normal", "normal");
element.style.display = "grid";
-element.style.justifyContent = "auto";
-checkValues(element, "justifyContent", "justify-content", "auto", "start");
+element.style.justifyContent = "normal";
+checkValues(element, "justifyContent", "justify-content", "normal", "normal");
element.style.justifyContent = "flex-end";
checkValues(element, "justifyContent", "justify-content", "flex-end", "flex-end");
@@ -309,6 +309,7 @@ element = document.createElement("div");
document.body.appendChild(element);
checkBadValues(element, "justifyContent", "justify-content", "");
+checkBadValues(element, "justifyContent", "justify-content", "auto");
checkBadValues(element, "justifyContent", "justify-content", "unsafe auto");
checkBadValues(element, "justifyContent", "justify-content", "auto safe");
checkBadValues(element, "justifyContent", "justify-content", "auto left");
@@ -333,17 +334,17 @@ checkBadValues(element, "justifyContent", "justify-content", "safe");
debug("");
debug("Test the value 'initial'");
element.style.display = "";
-checkInitialValues(element, "justifyContent", "justify-content", "stretch center", "start");
+checkInitialValues(element, "justifyContent", "justify-content", "stretch center", "normal");
debug("");
debug("Test the value 'initial' for grid containers");
element.style.display = "grid";
-checkInitialValues(element, "justifyContent", "justify-content", "space-between left", "start");
+checkInitialValues(element, "justifyContent", "justify-content", "space-between left", "normal");
debug("");
debug("Test the value 'initial' for flex containers");
element.style.display = "flex";
-checkInitialValues(element, "justifyContent", "justify-content", "right unsafe", "flex-start");
+checkInitialValues(element, "justifyContent", "justify-content", "right unsafe", "normal");
debug("");
debug("Test the value 'inherit'");
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/alignment/parse-align-content-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/alignment/parse-justify-content-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698