Auto-generate V8CSSStyleDeclaration::namedPropertyGetter

Auto-generate V8CSSStyleDeclaration::namedPropertyGetter

Remove V8CSSStyleDeclaration::namedPropertyGetter
in V8CSSStyleDeclarationCustom.cpp

also fixed check logic for union member.

R=haraken@chromium.org
BUG=229740
TEST=TestInterface.idl
NOTRY=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151201

[kojih, 2013-05-24 05:41:54]

r?

Diff of generated code:

+v8::Handle<v8::Value>
V8CSSStyleDeclaration::namedPropertyGetter(v8::Local<v8::String> name, const
v8::AccessorInfo& inf
o)
+{
+    if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(name).IsEmpty())
+        return v8Undefined();
+    if (info.Holder()->HasRealNamedCallbackProperty(name))
+        return v8Undefined();
+
+    ASSERT(V8DOMWrapper::maybeDOMWrapper(info.Holder()));
+    CSSStyleDeclaration* collection = toNative(info.Holder());
+    AtomicString propertyName = toWebCoreAtomicString(name);
+    bool element0Enabled = false;
+    String element0;
+    bool element1Enabled = false;
+    float element1;
+    collection->anonymousNamedGetter(propertyName, element0Enabled, element0,
element1Enabled, element1);
+    if (element0Enabled)
+        return v8StringOrNull(element0, info.GetIsolate());
+    if (element1Enabled)
+        return v8::Number::New(element1);
+    return v8Undefined();
+}

https://codereview.chromium.org/15834008/diff/1/Source/bindings/scripts/CodeG...
File Source/bindings/scripts/CodeGeneratorV8.pm (right):

https://codereview.chromium.org/15834008/diff/1/Source/bindings/scripts/CodeG...
Source/bindings/scripts/CodeGeneratorV8.pm:4733: my $code = "";
isNotNull check must not exist, because there is a case element0Enabled and
element0.isNull().
CSSStyleDeclaration is one of example, element0 is DOMString and
[TreatReturnedNullStringAs=Null].

[haraken, 2013-05-24 06:03:05]

LGTM

https://codereview.chromium.org/15834008/diff/1/Source/bindings/scripts/CodeG...
File Source/bindings/scripts/CodeGeneratorV8.pm (right):

https://codereview.chromium.org/15834008/diff/1/Source/bindings/scripts/CodeG...
Source/bindings/scripts/CodeGeneratorV8.pm:4733: my $code = "";

Makes sense.

https://codereview.chromium.org/15834008/diff/1/Source/core/core.gypi
File Source/core/core.gypi (right):

https://codereview.chromium.org/15834008/diff/1/Source/core/core.gypi#newcode606
Source/core/core.gypi:606: 'css/CSSStyleDeclaration.cpp',

Please add css/CSSStyleDeclaration.h for consistency.

https://codereview.chromium.org/15834008/diff/1/Source/core/css/CSSStyleDecla...
File Source/core/css/CSSStyleDeclaration.cpp (right):

https://codereview.chromium.org/15834008/diff/1/Source/core/css/CSSStyleDecla...
Source/core/css/CSSStyleDeclaration.cpp:156: //        return
v8StringOrNull(cssValue->cssText(), info.GetIsolate());

I think it is already supported by [TreatReturnedNullStringAs=Null]. If so,
remove this comment. If not, let's support it in this CL (otherwise the CL will
change existing behavior).

[kojih, 2013-05-24 06:11:19]

https://codereview.chromium.org/15834008/diff/1/Source/core/css/CSSStyleDecla...
File Source/core/css/CSSStyleDeclaration.cpp (right):

https://codereview.chromium.org/15834008/diff/1/Source/core/css/CSSStyleDecla...
Source/core/css/CSSStyleDeclaration.cpp:156: //        return
v8StringOrNull(cssValue->cssText(), info.GetIsolate());
Ah this is just my old memo. I'll remove this.

[commit-bot: I haz the power, 2013-05-27 01:11:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kojih@chromium.org/15834008/10001

[commit-bot: I haz the power, 2013-05-27 01:11:58]

Failed to apply patch for Source/bindings/scripts/CodeGeneratorV8.pm:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/bindings/scripts/CodeGeneratorV8.pm
  Hunk #1 FAILED at 4730.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/bindings/scripts/CodeGeneratorV8.pm.rej

Patch:       Source/bindings/scripts/CodeGeneratorV8.pm
Index: Source/bindings/scripts/CodeGeneratorV8.pm
diff --git a/Source/bindings/scripts/CodeGeneratorV8.pm
b/Source/bindings/scripts/CodeGeneratorV8.pm
index
30fd8ac3e57ebdb1c8c19dcacd21b40ae9f352e6..72298f1268e08778d59c6040bdc4003a72092a2a
100644
--- a/Source/bindings/scripts/CodeGeneratorV8.pm
+++ b/Source/bindings/scripts/CodeGeneratorV8.pm
@@ -4730,10 +4730,8 @@ sub NativeToJSValue
             my $unionMemberNativeValue = $unionMemberVariable;
             $unionMemberNativeValue .= ".release()" if
(IsRefPtrType($unionMemberType));
             my $returnJSValueCode = NativeToJSValue($unionMemberType,
$extendedAttributes, $unionMemberNativeValue, $indent . "    ", $receiver,
$getCreationContext, $getIsolate, $getHolderContainer, $getScriptWrappable,
$returnHandleType, $forMainWorldSuffix);
-            my $isNotNull = GenerateIsNullExpression($unionMemberType,
$unionMemberVariable);
-            $isNotNull = " && !" . $isNotNull if $isNotNull;
             my $code = "";
-            $code .= "${indent}if
(${unionMemberEnabledVariable}${isNotNull})\n";
+            $code .= "${indent}if (${unionMemberEnabledVariable})\n";
             $code .= "${returnJSValueCode}";
             push @codes, $code;
         }

[commit-bot: I haz the power, 2013-05-27 04:34:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kojih@chromium.org/15834008/18001

[commit-bot: I haz the power, 2013-05-27 06:46:06]

Failed to apply patch for Source/core/dom/NodeList.cpp:
File exist but was about to be overwriten
Patch:   NR  Source/core/html/ime/Composition.cpp->Source/core/dom/NodeList.cpp
Index: Source/core/dom/NodeList.cpp
diff --git a/Source/core/html/ime/Composition.cpp b/Source/core/dom/NodeList.cpp
similarity index 73%
copy from Source/core/html/ime/Composition.cpp
copy to Source/core/dom/NodeList.cpp
index
49b0bf119ebebe9c2904d5fd22f22b064b84ee90..fb06c70817bff7406297e671ca5dd5f5ff7f29e6
100644
--- a/Source/core/html/ime/Composition.cpp
+++ b/Source/core/dom/NodeList.cpp
@@ -29,26 +29,29 @@
  */
 
 #include "config.h"
-#include "core/html/ime/Composition.h"
+#include "core/dom/NodeList.h"
 
 #include "core/dom/Node.h"
-#include "core/dom/Range.h"
 
 namespace WebCore {
 
-Composition::~Composition()
+void NodeList::anonymousNamedGetter(const AtomicString& name, bool&
returnValue0Enabled, RefPtr<Node>& returnValue0, bool& returnValue1Enabled,
unsigned& returnValue1)
 {
-}
+    // Length property cannot be overridden.
+    DEFINE_STATIC_LOCAL(const AtomicString, length, ("length",
AtomicString::ConstructFromLiteral));
+    if (name == length) {
+        returnValue1Enabled = true;
+        returnValue1 = this->length();
+        return;
+    }
 
-PassRefPtr<Composition> Composition::create(Node* text, Range* caret)
-{
-    return adoptRef(new Composition(text, caret));
-}
+    Node* result = namedItem(name);
+    if (!result)
+        return;
 
-Composition::Composition(Node* text, Range* caret)
-    : m_text(text)
-    , m_caret(caret)
-{
+    returnValue0Enabled = true;
+    returnValue0 = result;
 }
 
+
 } // namespace WebCore

[commit-bot: I haz the power, 2013-05-27 06:52:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kojih@chromium.org/15834008/29001

[commit-bot: I haz the power, 2013-05-27 07:40:05]

Retried try job too often on linux_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layo...

[commit-bot: I haz the power, 2013-05-27 07:44:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kojih@chromium.org/15834008/29001

[commit-bot: I haz the power, 2013-05-27 08:30:30]

Retried try job too often on linux_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layo...

[commit-bot: I haz the power, 2013-05-27 08:31:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kojih@chromium.org/15834008/29001

[commit-bot: I haz the power, 2013-05-27 09:15:02]

Retried try job too often on linux_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layo...

[commit-bot: I haz the power, 2013-05-27 09:31:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kojih@chromium.org/15834008/29001

[commit-bot: I haz the power, 2013-05-27 11:51:07]

Retried try job too often on win_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...

[commit-bot: I haz the power, 2013-05-27 15:37:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kojih@chromium.org/15834008/29001

[commit-bot: I haz the power, 2013-05-27 17:23:03]

Retried try job too often on win_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...

[commit-bot: I haz the power, 2013-05-27 22:19:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kojih@chromium.org/15834008/29001

[commit-bot: I haz the power, 2013-05-28 00:02:16]

Retried try job too often on win_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...

[commit-bot: I haz the power, 2013-05-28 00:13:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kojih@chromium.org/15834008/29001

[commit-bot: I haz the power, 2013-05-28 00:34:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kojih@chromium.org/15834008/29001

[commit-bot: I haz the power, 2013-05-28 00:47:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kojih@chromium.org/15834008/29001

[commit-bot: I haz the power, 2013-05-28 00:47:52]

Change committed as 151201