Source/bindings/scripts/CodeGeneratorV8.pm - Issue 15834008: Auto-generate V8CSSStyleDeclaration::namedPropertyGetter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/CodeGeneratorV8.pm

Issue 15834008: Auto-generate V8CSSStyleDeclaration::namedPropertyGetter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master

Patch Set: rebased Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/CodeGeneratorV8.pm

diff --git a/Source/bindings/scripts/CodeGeneratorV8.pm b/Source/bindings/scripts/CodeGeneratorV8.pm

index 30fd8ac3e57ebdb1c8c19dcacd21b40ae9f352e6..72298f1268e08778d59c6040bdc4003a72092a2a 100644

--- a/Source/bindings/scripts/CodeGeneratorV8.pm

+++ b/Source/bindings/scripts/CodeGeneratorV8.pm

@@ -4730,10 +4730,8 @@ sub NativeToJSValue

my $unionMemberNativeValue = $unionMemberVariable;

$unionMemberNativeValue .= ".release()" if (IsRefPtrType($unionMemberType));

my $returnJSValueCode = NativeToJSValue($unionMemberType, $extendedAttributes, $unionMemberNativeValue, $indent . " ", $receiver, $getCreationContext, $getIsolate, $getHolderContainer, $getScriptWrappable, $returnHandleType, $forMainWorldSuffix);

- my $isNotNull = GenerateIsNullExpression($unionMemberType, $unionMemberVariable);

- $isNotNull = " && !" . $isNotNull if $isNotNull;

my $code = "";

- $code .= "${indent}if (${unionMemberEnabledVariable}${isNotNull})\n";

+ $code .= "${indent}if (${unionMemberEnabledVariable})\n";

$code .= "${returnJSValueCode}";

push @codes, $code;

}

« no previous file with comments | « no previous file | Source/bindings/tests/results/V8TestInterface.cpp » ('j') | no next file with comments »