[DevTools] Support source map with blackboxing in call frame sidebar, console

[DevTools] Support source map with blackboxing in call frame sidebar, console

If source has sourceMap and callFrame location maps to blackboxed source url then blackbox it in stack traces in console and in call frame sidebar.

BUG=341082
R=dgozman@chromium.org

[kozy, 2016-01-27 23:01:24]

please take a look.

[pfeldman, 2016-01-28 01:20:02]

pfeldman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[pfeldman, 2016-01-28 01:20:03]

We probably want a test for this.

https://codereview.chromium.org/1649553002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/bindings/BlackboxSupport.js
(right):

https://codereview.chromium.org/1649553002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/bindings/BlackboxSupport.js:115:
WebInspector.BlackboxSupport.isBlackboxed = function(url, isContentScript)
Does it ever make sense for the client to call into it? (should it be private?)

[kozy, 2016-01-28 02:35:48]

Added a test.

https://codereview.chromium.org/1649553002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/bindings/BlackboxSupport.js
(right):

https://codereview.chromium.org/1649553002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/bindings/BlackboxSupport.js:115:
WebInspector.BlackboxSupport.isBlackboxed = function(url, isContentScript)
On 2016/01/28 01:20:03, pfeldman wrote:
> Does it ever make sense for the client to call into it? (should it be
private?)

There is usage in TimelineFlameChart.js [1]

[1]
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

[pfeldman, 2016-01-28 18:28:51]

> There is usage in TimelineFlameChart.js [1]

Which I think you should migrate to the scriptId version so that it was
consistent with the debugging.

> 
> [1]
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

[kozy, 2016-01-28 19:52:51]

On 2016/01/28 18:28:51, pfeldman wrote:
> > There is usage in TimelineFlameChart.js [1]
> 
> Which I think you should migrate to the scriptId version so that it was
> consistent with the debugging.
> 
> > 
> > [1]
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

Sorry, there is usage in JavaScriptSourceFrame.js not in Timeline and I think we
can use url here because if we've source map then we show user source file
instead compiled and infobar for it.

[kozy, 2016-02-16 19:31:06]

Description was changed from

==========
[DevTools] Support source map with blackboxing in call frame sidebar, console

If source has sourceMap and callFrame location maps to blackboxed source url
then blackbox it in stack traces in console and in call frame sidebar.

BUG=341082
R=dgozman@chromium.org
==========

to

==========
[DevTools] Support source map with blackboxing in call frame sidebar, console

If source has sourceMap and callFrame location maps to blackboxed source url
then blackbox it in stack traces in console and in call frame sidebar.

BUG=341082
R=dgozman@chromium.org
==========

[kozy, 2016-02-16 19:31:37]

Different approach was implemented: LiveLocations with blackbox support.
https://codereview.chromium.org/1688283002/