third_party/WebKit/Source/core/dom/IntersectionObserverCallback.h - Issue 1583173002: Add virtual destructors to IntersectionObserverCallback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/IntersectionObserverCallback.h

Issue 1583173002: Add virtual destructors to IntersectionObserverCallback (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Remove unnecessary destructors Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/dom/IntersectionObserverCallback.h

diff --git a/third_party/WebKit/Source/core/dom/IntersectionObserverCallback.h b/third_party/WebKit/Source/core/dom/IntersectionObserverCallback.h

index d701090ab1fd706637bc5a51ea53dd9a3dd779b5..7f4fe8b06715f8859bb35b6781731ccaa96e1a96 100644

--- a/third_party/WebKit/Source/core/dom/IntersectionObserverCallback.h

+++ b/third_party/WebKit/Source/core/dom/IntersectionObserverCallback.h

@@ -15,6 +15,7 @@ class IntersectionObserverEntry;

class IntersectionObserverCallback : public GarbageCollectedFinalized<IntersectionObserverCallback> {

public:

+ virtual ~IntersectionObserverCallback() {}

virtual void handleEvent(const HeapVector<Member<IntersectionObserverEntry>>&, IntersectionObserver&) = 0;

virtual ExecutionContext* executionContext() const = 0;

DEFINE_INLINE_VIRTUAL_TRACE() { }

« no previous file with comments | « third_party/WebKit/Source/core/dom/IntersectionObserver.h ('k') | no next file » | no next file with comments »