Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: third_party/WebKit/Source/core/dom/IntersectionObserver.h

Issue 1583173002: Add virtual destructors to IntersectionObserverCallback (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Remove unnecessary destructors Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/IntersectionObserver.h
diff --git a/third_party/WebKit/Source/core/dom/IntersectionObserver.h b/third_party/WebKit/Source/core/dom/IntersectionObserver.h
index 79d8c278613d9b812fea1e8e11bc8c8051df0a41..f793a6f958543add45b3d8b5810b6d6c2297357d 100644
--- a/third_party/WebKit/Source/core/dom/IntersectionObserver.h
+++ b/third_party/WebKit/Source/core/dom/IntersectionObserver.h
@@ -20,6 +20,7 @@ class ExceptionState;
class IntersectionObserverCallback;
class IntersectionObserverInit;
+// TODO(oilpan): Switch to GarbageCollected<> after oilpan ships
class IntersectionObserver final : public GarbageCollectedFinalized<IntersectionObserver>, public ScriptWrappable {
DEFINE_WRAPPERTYPEINFO();

Powered by Google App Engine
This is Rietveld 408576698