Issue 1583073004: Merge to XFA: Correct the way to count pages and to avoid infinite loop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1583073004: Merge to XFA: Correct the way to count pages and to avoid infinite loop (Closed)

Created:
4 years, 11 months ago by Wei Li

Modified:
4 years, 11 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Correct the way to count pages and to avoid infinite loop BUG=pdfium:360 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1585823003 . (cherry picked from commit 5d5d9fe7bd1c9566b9d6570015b7c60894d9fc0c) Committed: https://pdfium.googlesource.com/pdfium/+/215816b7450a577e186cc0e5f1634c4c6610b86b

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+80 lines, -46 lines)			Patch
M	core/include/fpdfapi/fpdf_parser.h	View	2 chunks	+17 lines, -1 line	0 comments	Download
M	core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp	View	5 chunks	+44 lines, -31 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp	View	1 chunk	+0 lines, -14 lines	0 comments	Download
M	fpdfsdk/src/fpdfview_embeddertest.cpp	View	1 chunk	+5 lines, -0 lines	0 comments	Download
A	testing/resources/bug_360.pdf	View	1 chunk	+14 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Wei Li

Committed patchset #1 (id:1) manually as 215816b7450a577e186cc0e5f1634c4c6610b86b (presubmit successful).

4 years, 11 months ago (2016-01-14 20:29:07 UTC) #3

Message was sent while issue was closed.

lgtm