Correct the way to count pages and to avoid infinite loop

Correct the way to count pages and to avoid infinite loop

BUG=pdfium:360
R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/5d5d9fe7bd1c9566b9d6570015b7c60894d9fc0c

[Wei Li, 2016-01-14 01:16:24]

weili@chromium.org changed reviewers:
+ thestig@chromium.org

[Wei Li, 2016-01-14 01:16:25]

PTAL, thanks

[Lei Zhang, 2016-01-14 19:22:40]

https://codereview.chromium.org/1585823003/diff/20001/core/include/fpdfapi/fp...
File core/include/fpdfapi/fpdf_parser.h (right):

https://codereview.chromium.org/1585823003/diff/20001/core/include/fpdfapi/fp...
core/include/fpdfapi/fpdf_parser.h:185: // Retrieve page count information by
getting |count| from the tree nodes or
There's no parameter named "count" here.

https://codereview.chromium.org/1585823003/diff/20001/core/src/fpdfapi/fpdf_p...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp (right):

https://codereview.chromium.org/1585823003/diff/20001/core/src/fpdfapi/fpdf_p...
core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp:17:
std::set<CPDF_Dictionary*>* counting_pages) {
counted_pages or encountered_pages?

https://codereview.chromium.org/1585823003/diff/20001/core/src/fpdfapi/fpdf_p...
core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp:32: if
(!pKid->KeyExist("Kids")) {
Do you want to remove the '!' and flip the if/else blocks?

[Wei Li, 2016-01-14 19:41:27]

Patchset #3 (id:40001) has been deleted

[Wei Li, 2016-01-14 19:46:00]

https://codereview.chromium.org/1585823003/diff/20001/core/include/fpdfapi/fp...
File core/include/fpdfapi/fpdf_parser.h (right):

https://codereview.chromium.org/1585823003/diff/20001/core/include/fpdfapi/fp...
core/include/fpdfapi/fpdf_parser.h:185: // Retrieve page count information by
getting |count| from the tree nodes or
On 2016/01/14 19:22:39, Lei Zhang wrote:
> There's no parameter named "count" here.

Done.

https://codereview.chromium.org/1585823003/diff/20001/core/src/fpdfapi/fpdf_p...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp (right):

https://codereview.chromium.org/1585823003/diff/20001/core/src/fpdfapi/fpdf_p...
core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp:17:
std::set<CPDF_Dictionary*>* counting_pages) {
On 2016/01/14 19:22:39, Lei Zhang wrote:
> counted_pages or encountered_pages?

Those pages are not counted yet. Chose a textbook classic name :)

https://codereview.chromium.org/1585823003/diff/20001/core/src/fpdfapi/fpdf_p...
core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp:32: if
(!pKid->KeyExist("Kids")) {
On 2016/01/14 19:22:39, Lei Zhang wrote:
> Do you want to remove the '!' and flip the if/else blocks?

Done.

[Lei Zhang, 2016-01-14 19:59:53]

lgtm

[Wei Li, 2016-01-14 20:10:25]

Description was changed from

==========
Correct the way to count pages and to avoid infinite loop

BUG=pdfium:360
==========

to

==========
Correct the way to count pages and to avoid infinite loop

BUG=pdfium:360
R=thestig@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/5d5d9fe7bd1c9566b9d6570015b7c60894d9...
==========

[Wei Li, 2016-01-14 20:10:27]

Committed patchset #3 (id:60001) manually as
5d5d9fe7bd1c9566b9d6570015b7c60894d9fc0c (presubmit successful).