Make copy_asan_runtime_dylib.sh handle Clang version number changes

Make copy_asan_runtime_dylib.sh handle Clang version number changes

There's no need to use 'find' here; the script should ask update.py
for the version number.

BUG=none
R=thakis@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/439cedca2e412836e410e8b9b22679d0d4c74452

[hans, 2016-01-14 16:58:44]

hans@chromium.org changed reviewers:
+ thakis@chromium.org

[hans, 2016-01-14 16:58:45]

Not tested yet, I'll do that in a sec..

Is there a handy way to break the long line in Bash?

[Nico, 2016-01-14 17:05:18]

https://codereview.chromium.org/1582823004/diff/1/build/mac/copy_asan_runtime...
File build/mac/copy_asan_runtime_dylib.sh (right):

https://codereview.chromium.org/1582823004/diff/1/build/mac/copy_asan_runtime...
build/mac/copy_asan_runtime_dylib.sh:41:
ASAN_DYLIB="../../third_party/llvm-build/Release+Asserts/lib/clang/$(python
../../tools/clang/scripts/update.py
--print-clang-version)/lib/darwin/${ASAN_DYLIB_NAME}"
you probably want to keep ${BUILT_PRODUCTS_DIR} at the front -- you don't know
what the pwd is when this file is executed

To make the line shorter:
SRCROOT="${BUILT_PRODUCTS_DIR}/../.."
CLANGVER=$(python ${SRCROOT}/tools/clang/scripts/update.py
--print-clang-version)
ASAN_DYLIB=${SRCROOT}/third_party/llvm-build/Release+Asserts/lib/clang/${CLANGVER}/lib/darwin/${ASAN_DYLIB_NAME}

[hans, 2016-01-14 17:35:56]

Thanks! Uploading new version, that I also tested locally.

https://codereview.chromium.org/1582823004/diff/1/build/mac/copy_asan_runtime...
File build/mac/copy_asan_runtime_dylib.sh (right):

https://codereview.chromium.org/1582823004/diff/1/build/mac/copy_asan_runtime...
build/mac/copy_asan_runtime_dylib.sh:41:
ASAN_DYLIB="../../third_party/llvm-build/Release+Asserts/lib/clang/$(python
../../tools/clang/scripts/update.py
--print-clang-version)/lib/darwin/${ASAN_DYLIB_NAME}"
On 2016/01/14 17:05:18, Nico (afk today Thu Jan 14) wrote:
> you probably want to keep ${BUILT_PRODUCTS_DIR} at the front -- you don't know
> what the pwd is when this file is executed

Gah, I somehow missed that one.

> To make the line shorter:
> SRCROOT="${BUILT_PRODUCTS_DIR}/../.."
> CLANGVER=$(python ${SRCROOT}/tools/clang/scripts/update.py
> --print-clang-version)
>
ASAN_DYLIB=${SRCROOT}/third_party/llvm-build/Release+Asserts/lib/clang/${CLANGVER}/lib/darwin/${ASAN_DYLIB_NAME}

Thanks, let's do that.

[Nico, 2016-01-14 17:51:08]

lgtm, thanks!

[hans, 2016-01-14 17:52:33]

The CQ bit was checked by hans@chromium.org

[commit-bot: I haz the power, 2016-01-14 17:52:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1582823004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1582823004/20001

[commit-bot: I haz the power, 2016-01-14 18:05:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-14 18:05:37]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[commit-bot: I haz the power, 2016-01-14 18:14:31]

Description was changed from

==========
Make copy_asan_runtime_dylib.sh handle Clang version number changes

There's no need to use 'find' here; the script should ask update.py
for the version number.

BUG=none
==========

to

==========
Make copy_asan_runtime_dylib.sh handle Clang version number changes

There's no need to use 'find' here; the script should ask update.py
for the version number.

BUG=none
R=thakis@chromium.org

Committed: https://crrev.com/439cedca2e412836e410e8b9b22679d0d4c74452
Cr-Commit-Position: refs/heads/master@{#369464}
==========

[commit-bot: I haz the power, 2016-01-14 18:14:31]

Patchset 2 (id:??) landed as
https://crrev.com/439cedca2e412836e410e8b9b22679d0d4c74452
Cr-Commit-Position: refs/heads/master@{#369464}

[hans, 2016-01-14 18:15:08]

Description was changed from

==========
Make copy_asan_runtime_dylib.sh handle Clang version number changes

There's no need to use 'find' here; the script should ask update.py
for the version number.

BUG=none
R=thakis@chromium.org

Committed: https://crrev.com/439cedca2e412836e410e8b9b22679d0d4c74452
Cr-Commit-Position: refs/heads/master@{#369464}
==========

to

==========
Make copy_asan_runtime_dylib.sh handle Clang version number changes

There's no need to use 'find' here; the script should ask update.py
for the version number.

BUG=none
R=thakis@chromium.org

Committed:
https://chromium.googlesource.com/chromium/src/+/439cedca2e412836e410e8b9b226...
==========

[hans, 2016-01-14 18:15:09]

Committed patchset #2 (id:20001) manually as
439cedca2e412836e410e8b9b22679d0d4c74452 (presubmit successful).