Make copy_asan_runtime_dylib.sh handle Clang version number changes

build/mac/copy_asan_runtime_dylib.sh

 #!/bin/bash
 
 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # For app bundles built with ASan, copies the runtime lib
 # (libclang_rt.asan_osx_dynamic.dylib), on which their executables depend, from
 # the compiler installation path into the bundle and fixes the dylib's install
 # name in the binary to be relative to @executable_path.
@@ skipping 20 matching lines @@
   ASAN_DYLIB_NAME=libclang_rt.asan_osx_dynamic.dylib
 fi
 
 if [[ -z "${BUILTIN_DYLIB_PATH}" ]]; then
   echo "${BINARY} does not depend on the ASan runtime library!" >&2
   exit 1
 fi
 
 # TODO(glider): this doesn't work if we set CC and CXX to override the default
 # Clang.
-ASAN_DYLIB=$(find \
-    "${BUILT_PRODUCTS_DIR}/../../third_party/llvm-build/Release+Asserts/lib/clang/" \
-    -type f -path "*${ASAN_DYLIB_NAME}")
+ASAN_DYLIB="../../third_party/llvm-build/Release+Asserts/lib/clang/$(python ../../tools/clang/scripts/update.py --print-clang-version)/lib/darwin/${ASAN_DYLIB_NAME}"

[Nico, 2016/01/14 17:05:18]

you probably want to keep ${BUILT_PRODUCTS_DIR} at the front -- you don't know
what the pwd is when this file is executed

To make the line shorter:
SRCROOT="${BUILT_PRODUCTS_DIR}/../.."
CLANGVER=$(python ${SRCROOT}/tools/clang/scripts/update.py
--print-clang-version)
ASAN_DYLIB=${SRCROOT}/third_party/llvm-build/Release+Asserts/lib/clang/${CLANGVER}/lib/darwin/${ASAN_DYLIB_NAME}

[hans, 2016/01/14 17:35:56]

Gah, I somehow missed that one.
Thanks, let's do that.

 
 DYLIB_BASENAME=$(basename "${ASAN_DYLIB}")
 if [[ "${DYLIB_BASENAME}" != "${ASAN_DYLIB_NAME}" ]]; then
   echo "basename(${ASAN_DYLIB}) != ${ASAN_DYLIB_NAME}" >&2
   exit 1
 fi
 
 # Check whether the directory containing the executable binary is named
 # "MacOS". In this case we're building a full-fledged OSX app and will put
 # the runtime into appname.app/Contents/Libraries/. Otherwise this is probably
@@ skipping 13 matching lines @@
 # Make LC_ID_DYLIB of the runtime copy point to its location.
 install_name_tool \
     -id "${NEW_LC_ID_DYLIB}" \
     "${LIBRARIES_DIR}/${ASAN_DYLIB_NAME}"
 
 # Fix the rpath to the runtime library recorded in the binary.
 install_name_tool \
     -change "${BUILTIN_DYLIB_PATH}" \
     "${NEW_LC_ID_DYLIB}" \
     "${BINARY}"