[Telemetry] Update all clients to use chromium_config.GetTelemetryDir()

[Telemetry] Update all clients to use chromium_config.GetTelemetryDir()

Telemetry is soon to move to Catapult. The effect will be that Telemetry will
begin to be located at src/third_party/catapult/telemetry, rather than
tools/telemetry.

This CL updates all src-side Telemetry clients to use
chromium_config.GetTelemetryDir(), which is a helper that Telemetry team will
update when the move is complete.

BUG=576374
Committed: https://crrev.com/a5d5d3d6b40905cf3dd3ead516b9c42bf9b94aff
Cr-Commit-Position: refs/heads/master@{#371013}

[eakuefner, 2016-01-14 18:27:08]

eakuefner@chromium.org changed reviewers:
+ aiolos@chromium.org, bustamante@chromium.org, dtu@chromium.org,
isherman@chromium.org, kbr@chromium.org, nednguyen@google.com,
pasko@chromium.org, pauljensen@chromium.org, prasadv@chromium.org,
qyearsley@chromium.org, robertocn@chromium.org

[eakuefner, 2016-01-14 18:27:08]

This CL updates all src-side Telemetry clients that I could find using this
regex
https://code.google.com/p/chromium/codesearch#search/&q=sys%5C.path%5C.(appen...
to indirect through chromium_config.GetTelemetryDir() in locating Telemetry,
which will allow Telemetry to move transparently to Catapult.

pauljensen: components/cronet
isherman: components/proximity_auth
kbr: content/test/gpu
pasko: tools/android/loading and tools/cygprofile
prasadv/robertocn: tools/*bisect*
bustamante: tools/chrome_proxy
nednguyen/aiolos: sanity check
qyearsley/dtu: FYI

[nednguyen, 2016-01-14 18:27:37]

Description was changed from

==========
[Telemetry] Update all clients to use chromium_config.GetTelemetryDir()

Telemetry is soon to move to Catapult. The effect will be that Telemetry will
begin to be located at src/third_party/catapult/telemetry, rather than
tools/telemetry.

This CL updates all src-side Telemetry clients to use
chromium_config.GetTelemetryDir(), which is a helper that Telemetry team will
update when the move is complete.

BUG=576374
==========

to

==========
[Telemetry] Update all clients to use chromium_config.GetTelemetryDir()

Telemetry is soon to move to Catapult. The effect will be that Telemetry will
begin to be located at src/third_party/catapult/telemetry, rather than
tools/telemetry.

This CL updates all src-side Telemetry clients to use
chromium_config.GetTelemetryDir(), which is a helper that Telemetry team will
update when the move is complete.

BUG=576374
==========

[nednguyen, 2016-01-14 18:27:37]

nednguyen@google.com changed reviewers:
+ bengr@chromium.org

[bustamante, 2016-01-14 21:02:01]

lgtm % nit for chrome_proxy code

https://codereview.chromium.org/1582793006/diff/1/tools/chrome_proxy/run_benc...
File tools/chrome_proxy/run_benchmark (right):

https://codereview.chromium.org/1582793006/diff/1/tools/chrome_proxy/run_benc...
tools/chrome_proxy/run_benchmark:9: import chrome_proxy_config
nit - The import statements should be grouped together with a line of white
space between them and sys.path.insert(...) here and in the other run_* files.

[Ken Russell (switch to Gerrit), 2016-01-14 21:16:42]

content/test/gpu lgtm if this passes the trybots.

[Ilya Sherman, 2016-01-14 21:53:28]

proximity_auth lgtm

[aiolos (Not reviewing), 2016-01-15 00:33:04]

tools/perf and sanity check LGTM with nits.

https://codereview.chromium.org/1582793006/diff/1/components/cronet/android/t...
File components/cronet/android/test/javaperftests/run.py (right):

https://codereview.chromium.org/1582793006/diff/1/components/cronet/android/t...
components/cronet/android/test/javaperftests/run.py:46:
sys.path.append(os.path.join(REPOSITORY_ROOT, 'tools', 'perf'))
Nit: You might want to check if it's already in the path before you add it.
(Similarly in the other files.)

https://codereview.chromium.org/1582793006/diff/1/content/test/gpu/gpu_tests/...
File content/test/gpu/gpu_tests/__init__.py (right):

https://codereview.chromium.org/1582793006/diff/1/content/test/gpu/gpu_tests/...
content/test/gpu/gpu_tests/__init__.py:10: os.path.dirname(__file__),
you should take the abspath of __file__ before taking the dirpath, just in case.

https://codereview.chromium.org/1582793006/diff/1/tools/bisect-manual-test.py
File tools/bisect-manual-test.py (right):

https://codereview.chromium.org/1582793006/diff/1/tools/bisect-manual-test.py...
tools/bisect-manual-test.py:14: sys.path.insert(1, 'perf')
Is there a reason you aren't using the full path here?

https://codereview.chromium.org/1582793006/diff/1/tools/perf/fetch_benchmark_...
File tools/perf/fetch_benchmark_deps.py (right):

https://codereview.chromium.org/1582793006/diff/1/tools/perf/fetch_benchmark_...
tools/perf/fetch_benchmark_deps.py:15: 
catapult_base and telemetry are arguably the same import level since they will
both be in catapult. We should decide on which convention we're using and stick
with it. (It's done both ways int he codebase currently.)

[dtu, 2016-01-15 00:36:49]

lgtm

[pauljensen, 2016-01-15 00:51:20]

lgtm

[pasko, 2016-01-15 12:52:36]

tools/android/loading and tools/cygprofile lgtm

[eakuefner, 2016-01-19 17:21:18]

Bisect folks: ping

https://codereview.chromium.org/1582793006/diff/1/components/cronet/android/t...
File components/cronet/android/test/javaperftests/run.py (right):

https://codereview.chromium.org/1582793006/diff/1/components/cronet/android/t...
components/cronet/android/test/javaperftests/run.py:46:
sys.path.append(os.path.join(REPOSITORY_ROOT, 'tools', 'perf'))
On 2016/01/15 at 00:33:04, aiolos wrote:
> Nit: You might want to check if it's already in the path before you add it.
(Similarly in the other files.)

Acknowledged, but I think I'll leave that up to the authors of client code. I
want to avoid making functional changes broader than switching the way that
Telemetry is referred to, and in this case, for example, I don't see why it
would be more likely for perf to have a double entry in the path than Telemetry.

https://codereview.chromium.org/1582793006/diff/1/content/test/gpu/gpu_tests/...
File content/test/gpu/gpu_tests/__init__.py (right):

https://codereview.chromium.org/1582793006/diff/1/content/test/gpu/gpu_tests/...
content/test/gpu/gpu_tests/__init__.py:10: os.path.dirname(__file__),
On 2016/01/15 at 00:33:04, aiolos wrote:
> you should take the abspath of __file__ before taking the dirpath, just in
case.

Done.

https://codereview.chromium.org/1582793006/diff/1/tools/bisect-manual-test.py
File tools/bisect-manual-test.py (right):

https://codereview.chromium.org/1582793006/diff/1/tools/bisect-manual-test.py...
tools/bisect-manual-test.py:14: sys.path.insert(1, 'perf')
On 2016/01/15 at 00:33:04, aiolos wrote:
> Is there a reason you aren't using the full path here?

Done. I've also switched back to append here because of my comment about not
wanting to make overly broad functional changes in this CL, and because there
was another place (GPU) where switching to insert actually broke the imports
because of a collision.

https://codereview.chromium.org/1582793006/diff/1/tools/chrome_proxy/run_benc...
File tools/chrome_proxy/run_benchmark (right):

https://codereview.chromium.org/1582793006/diff/1/tools/chrome_proxy/run_benc...
tools/chrome_proxy/run_benchmark:9: import chrome_proxy_config
On 2016/01/14 at 21:02:01, bustamante wrote:
> nit - The import statements should be grouped together with a line of white
space between them and sys.path.insert(...) here and in the other run_* files.

Done.

https://codereview.chromium.org/1582793006/diff/1/tools/perf/fetch_benchmark_...
File tools/perf/fetch_benchmark_deps.py (right):

https://codereview.chromium.org/1582793006/diff/1/tools/perf/fetch_benchmark_...
tools/perf/fetch_benchmark_deps.py:15: 
On 2016/01/15 at 00:33:04, aiolos wrote:
> catapult_base and telemetry are arguably the same import level since they will
both be in catapult. We should decide on which convention we're using and stick
with it. (It's done both ways int he codebase currently.)

Outside of Catapult, these are all just third-party imports that happen to live
in Catapult. I've grouped them together in the latest patch set, for a start.

[qyearsley, 2016-01-19 18:34:37]

On 2016/01/19 17:21:18, eakuefner wrote:
> Bisect folks: ping

FWIW, the changes in tools/run-bisect-manual-test.py and
tools/bisect-manual-test.py LGTM

[eakuefner, 2016-01-19 18:35:14]

On 2016/01/19 at 18:34:37, qyearsley wrote:
> On 2016/01/19 17:21:18, eakuefner wrote:
> > Bisect folks: ping
> 
> FWIW, the changes in tools/run-bisect-manual-test.py and
tools/bisect-manual-test.py LGTM

Thanks Quinten :)

[prasadv1, 2016-01-20 23:14:11]

prasadv@google.com changed reviewers:
+ prasadv@google.com

[prasadv1, 2016-01-20 23:14:12]

lgtm

[eakuefner, 2016-01-20 23:15:36]

The CQ bit was checked by eakuefner@chromium.org

[eakuefner, 2016-01-20 23:15:37]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
dtu@chromium.org, aiolos@chromium.org, pauljensen@chromium.org,
pasko@chromium.org, isherman@chromium.org, bustamante@chromium.org
Link to the patchset: https://codereview.chromium.org/1582793006/#ps20001
(title: "Address Richard and Kari's comments")

[commit-bot: I haz the power, 2016-01-20 23:17:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1582793006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1582793006/20001

[commit-bot: I haz the power, 2016-01-20 23:23:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-20 23:23:35]

Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[aiolos (Not reviewing), 2016-01-20 23:46:17]

You need to rebase. Still lgtm.

[eakuefner, 2016-01-21 00:58:50]

I've rebased, but the content/test/gpu unittests are broken at HEAD and I'd like
not to upload until they pass.

[eakuefner, 2016-01-21 01:14:10]

The CQ bit was checked by eakuefner@chromium.org

[eakuefner, 2016-01-21 01:14:10]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
dtu@chromium.org, aiolos@chromium.org, pasko@chromium.org,
pauljensen@chromium.org, prasadv@google.com, isherman@chromium.org,
qyearsley@chromium.org, bustamante@chromium.org
Link to the patchset: https://codereview.chromium.org/1582793006/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-01-21 01:15:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1582793006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1582793006/40001

[commit-bot: I haz the power, 2016-01-21 01:29:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-21 01:29:59]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[eakuefner, 2016-01-21 16:26:49]

Description was changed from

==========
[Telemetry] Update all clients to use chromium_config.GetTelemetryDir()

Telemetry is soon to move to Catapult. The effect will be that Telemetry will
begin to be located at src/third_party/catapult/telemetry, rather than
tools/telemetry.

This CL updates all src-side Telemetry clients to use
chromium_config.GetTelemetryDir(), which is a helper that Telemetry team will
update when the move is complete.

BUG=576374
==========

to

==========
[Telemetry] Update all clients to use chromium_config.GetTelemetryDir()

Telemetry is soon to move to Catapult. The effect will be that Telemetry will
begin to be located at src/third_party/catapult/telemetry, rather than
tools/telemetry.

This CL updates all src-side Telemetry clients to use
chromium_config.GetTelemetryDir(), which is a helper that Telemetry team will
update when the move is complete.

BUG=576374
TBR=prasadv@chromium.org
==========

[eakuefner, 2016-01-21 16:27:05]

Prasad, you stamped with @google so I'm TBRing your Chromium account.

[eakuefner, 2016-01-21 16:27:07]

The CQ bit was checked by eakuefner@chromium.org

[commit-bot: I haz the power, 2016-01-21 16:27:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1582793006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1582793006/40001

[commit-bot: I haz the power, 2016-01-21 16:37:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-21 16:37:56]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[RobertoCN, 2016-01-21 18:50:58]

lgtm

[eakuefner, 2016-01-22 18:25:18]

Description was changed from

==========
[Telemetry] Update all clients to use chromium_config.GetTelemetryDir()

Telemetry is soon to move to Catapult. The effect will be that Telemetry will
begin to be located at src/third_party/catapult/telemetry, rather than
tools/telemetry.

This CL updates all src-side Telemetry clients to use
chromium_config.GetTelemetryDir(), which is a helper that Telemetry team will
update when the move is complete.

BUG=576374
TBR=prasadv@chromium.org
==========

to

==========
[Telemetry] Update all clients to use chromium_config.GetTelemetryDir()

Telemetry is soon to move to Catapult. The effect will be that Telemetry will
begin to be located at src/third_party/catapult/telemetry, rather than
tools/telemetry.

This CL updates all src-side Telemetry clients to use
chromium_config.GetTelemetryDir(), which is a helper that Telemetry team will
update when the move is complete.

BUG=576374
==========

[eakuefner, 2016-01-22 18:25:45]

No longer TBR because of proper l-g-t-m from Roberto. Trying once more.

[eakuefner, 2016-01-22 18:25:47]

The CQ bit was checked by eakuefner@chromium.org

[eakuefner, 2016-01-22 18:25:47]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
robertocn@chromium.org, dtu@chromium.org, aiolos@chromium.org,
pasko@chromium.org, pauljensen@chromium.org, prasadv@google.com,
isherman@chromium.org, qyearsley@chromium.org, bustamante@chromium.org
Link to the patchset: https://codereview.chromium.org/1582793006/#ps60001
(title: "more rebase")

[commit-bot: I haz the power, 2016-01-22 18:26:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1582793006/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1582793006/60001

[commit-bot: I haz the power, 2016-01-22 19:48:45]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-01-22 19:50:26]

Description was changed from

==========
[Telemetry] Update all clients to use chromium_config.GetTelemetryDir()

Telemetry is soon to move to Catapult. The effect will be that Telemetry will
begin to be located at src/third_party/catapult/telemetry, rather than
tools/telemetry.

This CL updates all src-side Telemetry clients to use
chromium_config.GetTelemetryDir(), which is a helper that Telemetry team will
update when the move is complete.

BUG=576374
==========

to

==========
[Telemetry] Update all clients to use chromium_config.GetTelemetryDir()

Telemetry is soon to move to Catapult. The effect will be that Telemetry will
begin to be located at src/third_party/catapult/telemetry, rather than
tools/telemetry.

This CL updates all src-side Telemetry clients to use
chromium_config.GetTelemetryDir(), which is a helper that Telemetry team will
update when the move is complete.

BUG=576374

Committed: https://crrev.com/a5d5d3d6b40905cf3dd3ead516b9c42bf9b94aff
Cr-Commit-Position: refs/heads/master@{#371013}
==========

[commit-bot: I haz the power, 2016-01-22 19:50:28]

Patchset 4 (id:??) landed as
https://crrev.com/a5d5d3d6b40905cf3dd3ead516b9c42bf9b94aff
Cr-Commit-Position: refs/heads/master@{#371013}