Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Side by Side Diff: tools/bisect-manual-test.py

Issue 1582793006: [Telemetry] Update all clients to use chromium_config.GetTelemetryDir() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright 2013 The Chromium Authors. All rights reserved. 2 # Copyright 2013 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """Simple script which asks user to manually check result of bisection. 6 """Simple script which asks user to manually check result of bisection.
7 7
8 Typically used as by the run-bisect-manual-test.py script. 8 Typically used as by the run-bisect-manual-test.py script.
9 """ 9 """
10 10
11 import os 11 import os
12 import sys 12 import sys
13 13
14 sys.path.append(os.path.join(os.path.dirname(__file__), 'telemetry')) 14 sys.path.insert(1, 'perf')
aiolos (Not reviewing) 2016/01/15 00:33:04 Is there a reason you aren't using the full path h
eakuefner 2016/01/19 17:21:18 Done. I've also switched back to append here becau
15 from chrome_telemetry_build import chromium_config
16 sys.path.insert(1, chromium_config.GetTelemetryDir())
17
15 from telemetry.internal.browser import browser_finder 18 from telemetry.internal.browser import browser_finder
16 from telemetry.internal.browser import browser_options 19 from telemetry.internal.browser import browser_options
17 20
18 21
19 def _StartManualTest(options): 22 def _StartManualTest(options):
20 """Start browser then ask the user whether build is good or bad.""" 23 """Start browser then ask the user whether build is good or bad."""
21 browser_to_create = browser_finder.FindBrowser(options) 24 browser_to_create = browser_finder.FindBrowser(options)
22 print 'Starting browser: %s.' % options.browser_type 25 print 'Starting browser: %s.' % options.browser_type
23 with browser_to_create.Create(options) as _: 26 with browser_to_create.Create(options) as _:
24 # Loop until we get a response that we can parse. 27 # Loop until we get a response that we can parse.
(...skipping 15 matching lines...) Expand all
40 43
41 options = browser_options.BrowserFinderOptions() 44 options = browser_options.BrowserFinderOptions()
42 parser = options.CreateParser(usage) 45 parser = options.CreateParser(usage)
43 options, _ = parser.parse_args() 46 options, _ = parser.parse_args()
44 47
45 _StartManualTest(options) 48 _StartManualTest(options)
46 49
47 50
48 if __name__ == '__main__': 51 if __name__ == '__main__':
49 sys.exit(main()) 52 sys.exit(main())
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698