Disable taskkill failure when killing dart processes on windows.

Disable taskkill failure when killing dart processes on windows.

There is an outstanding issue with pub hanging and being unkillable on
windows.  Make the taskkill step pass on windows, even if there are
dart processes, until we fix this issue.

BUG=https://github.com/dart-lang/sdk/issues/24086
R=kustermann@google.com

Committed: https://github.com/dart-lang/sdk/commit/cd21da1d980b3e44c1c3554ce9ba9faeca7fffc5

[Bill Hesse, 2016-01-13 10:12:59]

whesse@google.com changed reviewers:
+ kustermann@google.com, ricow@google.com

[Bill Hesse, 2016-01-13 10:12:59]

I'm getting emails from all sites complaining about the taskkill redness, so I'm
making killing a dart process not a failure on windows, until we solve the pub
get hang.

[kustermann, 2016-01-13 10:15:28]

lgtm

[Bill Hesse, 2016-01-13 10:17:22]

Description was changed from

==========
Disable taskkill failure when killing dart processes on windows.

There is an outstanding issue with pub hanging and being unkillable on
windows.  Make the taskkill step pass on windows, even if there are
dart processes, until we fix this issue.

BUG=https://github.com/dart-lang/sdk/issues/24086
==========

to

==========
Disable taskkill failure when killing dart processes on windows.

There is an outstanding issue with pub hanging and being unkillable on
windows.  Make the taskkill step pass on windows, even if there are
dart processes, until we fix this issue.

BUG=https://github.com/dart-lang/sdk/issues/24086
R=kustermann@google.com

Committed:
https://github.com/dart-lang/sdk/commit/cd21da1d980b3e44c1c3554ce9ba9faeca7fffc5
==========

[Bill Hesse, 2016-01-13 10:17:23]

Committed patchset #1 (id:1) manually as
cd21da1d980b3e44c1c3554ce9ba9faeca7fffc5 (presubmit successful).

[ricow1, 2016-01-13 10:19:15]

except on the package waterfall I don't think this will help, on the next build
windows will be unable to build the vm (since it can't overwrite the dart
binary, because it is still running pub)

[kustermann, 2016-01-13 10:20:27]

in worst case, you could make them just autoreboot

[Bill Hesse, 2016-01-13 10:20:41]

On 2016/01/13 10:19:15, ricow1 wrote:
> except on the package waterfall I don't think this will help, on the next
build
> windows will be unable to build the vm (since it can't overwrite the dart
> binary, because it is still running pub)

I was thinking about that this morning, wondering why we weren't seeing this
failure more often.
But right now, we are rebooting before each build, so it should be only the
taskkill after running that was turning red.

[ricow1, 2016-01-13 10:24:00]

ricow@google.com changed reviewers:
+ mit@google.com

[ricow1, 2016-01-13 10:24:01]

ok, lgtm although this sucks
@mit  how do we get the priority (for more than Bill) of solving the underlying
issue bumped up