Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/task_kill.py

Issue 1582773002: Disable taskkill failure when killing dart processes on windows. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/task_kill.py
diff --git a/tools/task_kill.py b/tools/task_kill.py
index 4a54965319411cf521b958c3068280eaaf4b1cf0..ab07e8a7b0e5d8ca81db012d51b19c2ccb09c47a 100755
--- a/tools/task_kill.py
+++ b/tools/task_kill.py
@@ -206,7 +206,11 @@ def Main():
options = GetOptions()
status = 0
if options.kill_dart:
- status += KillDart()
+ if os_name == "win32":
+ # TODO(24086): Add result of KillDart into status once pub hang is fixed.
+ KillDart()
+ else:
+ status += KillDart()
if options.kill_fletch:
status += KillFletch()
if options.kill_vc:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698