Source/bindings/tests/results/V8TestSpecialOperationsIdentifierRaisesException.cpp - Issue 158273002: Remove [OverrideBuiltins] from HTMLCollection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestSpecialOperationsIdentifierRaisesException.cpp

Issue 158273002: Remove [OverrideBuiltins] from HTMLCollection (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/scripts/code_generator_v8.pm ('K') | « Source/bindings/tests/results/V8TestSpecialOperationsAnonymous.cpp ('k') | Source/bindings/tests/results/V8TestSpecialOperationsInt.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/V8TestSpecialOperationsIdentifierRaisesException.cpp

diff --git a/Source/bindings/tests/results/V8TestSpecialOperationsIdentifierRaisesException.cpp b/Source/bindings/tests/results/V8TestSpecialOperationsIdentifierRaisesException.cpp

index 457a804466564a428903ad69c330f7ceb877ed91..294156a878b58c5b8645c7eff20cead4789d36d7 100644

--- a/Source/bindings/tests/results/V8TestSpecialOperationsIdentifierRaisesException.cpp

+++ b/Source/bindings/tests/results/V8TestSpecialOperationsIdentifierRaisesException.cpp

@@ -271,12 +271,10 @@ static void indexedPropertyDeleterCallback(uint32_t index, const v8::PropertyCal

static void namedPropertyGetter(v8::Local<v8::String> name, const v8::PropertyCallbackInfo<v8::Value>& info)

{

- if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(name).IsEmpty())

- return;

- if (info.Holder()->HasRealNamedCallbackProperty(name))

- return;

if (info.Holder()->HasRealNamedProperty(name))

return;

+ if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(name).IsEmpty())

+ return;

TestSpecialOperationsIdentifierRaisesException* collection = V8TestSpecialOperationsIdentifierRaisesException::toNative(info.Holder());

AtomicString propertyName = toCoreAtomicString(name);

@@ -298,12 +296,10 @@ static void namedPropertyGetterCallback(v8::Local<v8::String> name, const v8::Pr

static void namedPropertySetter(v8::Local<v8::String> name, v8::Local<v8::Value> jsValue, const v8::PropertyCallbackInfo<v8::Value>& info)

{

- if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(name).IsEmpty())

- return;

- if (info.Holder()->HasRealNamedCallbackProperty(name))

- return;

if (info.Holder()->HasRealNamedProperty(name))

return;

+ if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(name).IsEmpty())

+ return;

TestSpecialOperationsIdentifierRaisesException* collection = V8TestSpecialOperationsIdentifierRaisesException::toNative(info.Holder());

V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, propertyName, name);