Remove [OverrideBuiltins] from HTMLCollection

Source/bindings/scripts/code_generator_v8.pm

Index: Source/bindings/scripts/code_generator_v8.pm
diff --git a/Source/bindings/scripts/code_generator_v8.pm b/Source/bindings/scripts/code_generator_v8.pm
index fb10155476c5611f30f9ec5469e76876d8495e80..970f86cc4bebba22b056a64c5922f969ff61b642 100644
--- a/Source/bindings/scripts/code_generator_v8.pm
+++ b/Source/bindings/scripts/code_generator_v8.pm
@@ -4081,12 +4081,10 @@ sub GenerateImplementationNamedPropertyGetter
     my $code = "static void namedPropertyGetter(v8::Local<v8::String> name, const v8::PropertyCallbackInfo<v8::Value>& info)\n";
     $code .= "{\n";
     if (!$interface->extendedAttributes->{"OverrideBuiltins"}) {
-        $code .= "    if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(name).IsEmpty())\n";
-        $code .= "        return;\n";
-        $code .= "    if (info.Holder()->HasRealNamedCallbackProperty(name))\n";
-        $code .= "        return;\n";
         $code .= "    if (info.Holder()->HasRealNamedProperty(name))\n";

[arv (Not doing code reviews), 2014/02/08 18:13:58]

I looked into this too.

I find this confusing. Maybe it is just bad V8 API names?

I would think we need to do something like:

1. Check own property for real property
2. Check prototype chain for real property
3. Check for own callback property
4. Check prototype chain for callback property

With this change, based on the (possibly bad) V8 names. It looks like we are
only doing 1 & 2.

Don't we need to look for callback properties to make sure that an ID/name is
not shadowing the length, item and namedItem?

[Inactive, 2014/02/08 18:57:04]

I looked at the V8 implementation and 
HasRealNamedProperty() works for callback properties as well. Therefore, I
believe the other check is redundant and can be removed.

[Inactive, 2014/02/08 21:34:04]

Here is the implementation of those 2 methods if you want to compare:
http://pastebin.com/AvmgTwuV

         $code .= "        return;\n";
+        $code .= "    if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(name).IsEmpty())\n";

[arv (Not doing code reviews), 2014/02/08 18:13:58]

So confusing. Why is this Get and not Has?

[Inactive, 2014/02/08 18:57:04]

This API does not have an Has equivalent for some reason, only a Get.

+        $code .= "        return;\n";
         $code .= "\n";
     }
     $code .= "    ${implClassName}* collection = ${v8ClassName}::toNative(info.Holder());\n";
@@ -4123,12 +4121,10 @@ sub GenerateImplementationNamedPropertySetter
     my $code = "static void namedPropertySetter(v8::Local<v8::String> name, v8::Local<v8::Value> jsValue, const v8::PropertyCallbackInfo<v8::Value>& info)\n";
     $code .= "{\n";
     if (!$interface->extendedAttributes->{"OverrideBuiltins"}) {
-        $code .= "    if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(name).IsEmpty())\n";
-        $code .= "        return;\n";
-        $code .= "    if (info.Holder()->HasRealNamedCallbackProperty(name))\n";
-        $code .= "        return;\n";
         $code .= "    if (info.Holder()->HasRealNamedProperty(name))\n";
         $code .= "        return;\n";
+        $code .= "    if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(name).IsEmpty())\n";
+        $code .= "        return;\n";
         $code .= "\n";
     }