chrome/browser/ui/fullscreen/fullscreen_controller_interactive_browsertest.cc - Issue 158253002: Tabs being screen-captured will fullscreen within their tab contents area.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/fullscreen/fullscreen_controller_interactive_browsertest.cc

Issue 158253002: Tabs being screen-captured will fullscreen within their tab contents area. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed scheib's review comments. Rebased. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/browser.cc ('K') | « chrome/browser/ui/fullscreen/fullscreen_controller.cc ('k') | chrome/browser/ui/fullscreen/fullscreen_controller_state_test.cc » ('j') | chrome/browser/ui/fullscreen/fullscreen_controller_state_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/fullscreen/fullscreen_controller_interactive_browsertest.cc

diff --git a/chrome/browser/ui/fullscreen/fullscreen_controller_interactive_browsertest.cc b/chrome/browser/ui/fullscreen/fullscreen_controller_interactive_browsertest.cc

index ca011155abcd606d48efbb09b2073f45aad3ac44..852e09358627997fd5aafb9c3bc6a30e268c1e9e 100644

--- a/chrome/browser/ui/fullscreen/fullscreen_controller_interactive_browsertest.cc

+++ b/chrome/browser/ui/fullscreen/fullscreen_controller_interactive_browsertest.cc

@@ -648,7 +648,7 @@ IN_PROC_BROWSER_TEST_F(FullscreenControllerInteractiveTest,

fullscreen_observer.Wait();

// Confirm they are enabled and there is no prompt.

- ASSERT_TRUE(IsFullscreenBubbleDisplayed());

+ ASSERT_FALSE(IsFullscreenBubbleDisplayed());

miu 2014/02/12 08:25:20 This test, that I originally authored, was broken

ASSERT_FALSE(IsFullscreenPermissionRequested());

ASSERT_FALSE(IsMouseLockPermissionRequested());

ASSERT_TRUE(IsMouseLocked());