Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1582423004: Fix pixel_test's arguments when run on tryservers. (Closed)

Created:
4 years, 11 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 11 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, iannucci, luqui, Sergey Berezin, Sergiy Byelozyorov
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix pixel_test's arguments when run on tryservers. When the tryservers start picking up the GPU tests from these JSON files, they must download, rather then upload, reference images from cloud storage. Also add buildername and got_revision variables. BUG=573321 TBR=phajdan.jr@chromium.org NOTRY=true Committed: https://crrev.com/247bf5a4e92425d0bd3a4dc4da51f55fe0d60fef Cr-Commit-Position: refs/heads/master@{#370582}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -12 lines) Patch
M testing/buildbot/chromium.gpu.fyi.json View 6 chunks +66 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Ken Russell (switch to Gerrit)
Please review. This depends on https://codereview.chromium.org/1588793002/ .
4 years, 11 months ago (2016-01-15 02:46:43 UTC) #2
Ken Russell (switch to Gerrit)
I'm landing this TBR'd in order to make more progress on this .json file today.
4 years, 11 months ago (2016-01-21 01:47:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1582423004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1582423004/20001
4 years, 11 months ago (2016-01-21 02:19:18 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-21 02:27:35 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/247bf5a4e92425d0bd3a4dc4da51f55fe0d60fef Cr-Commit-Position: refs/heads/master@{#370582}
4 years, 11 months ago (2016-01-21 02:29:20 UTC) #11
Paweł Hajdan Jr.
4 years, 11 months ago (2016-01-21 11:20:42 UTC) #12
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698