Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Unified Diff: testing/buildbot/chromium.gpu.fyi.json

Issue 1582423004: Fix pixel_test's arguments when run on tryservers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: testing/buildbot/chromium.gpu.fyi.json
diff --git a/testing/buildbot/chromium.gpu.fyi.json b/testing/buildbot/chromium.gpu.fyi.json
index 59df45b91f4541012f1171633703441f5cfd8594..136a315b5eb84d884d1a70bbf94bd7186648e0dc 100644
--- a/testing/buildbot/chromium.gpu.fyi.json
+++ b/testing/buildbot/chromium.gpu.fyi.json
@@ -259,17 +259,26 @@
"--browser=debug",
"-v",
"--extra-browser-args=\"--enable-logging=stderr --js-flags=--expose-gc\"",
- "--upload-refimg-to-cloud-storage",
"--refimg-cloud-storage-bucket",
"chromium-gpu-archive/reference-images",
"--os-type",
- "linux"
+ "linux",
+ "--build-revision",
+ "${got_revision}",
+ "--test-machine-name",
+ "${buildername}"
],
"isolate_name": "telemetry_gpu_test",
"name": "pixel_test",
+ "non_precommit_args": [
+ "--upload-refimg-to-cloud-storage"
+ ],
"override_compile_targets": [
"telemetry_gpu_test_run"
],
+ "precommit_args": [
+ "--download-refimg-from-cloud-storage"
+ ],
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
@@ -645,17 +654,26 @@
"--browser=release",
"-v",
"--extra-browser-args=\"--enable-logging=stderr --js-flags=--expose-gc\"",
- "--upload-refimg-to-cloud-storage",
"--refimg-cloud-storage-bucket",
"chromium-gpu-archive/reference-images",
"--os-type",
- "linux"
+ "linux",
+ "--build-revision",
+ "${got_revision}",
+ "--test-machine-name",
+ "${buildername}"
],
"isolate_name": "telemetry_gpu_test",
"name": "pixel_test",
+ "non_precommit_args": [
+ "--upload-refimg-to-cloud-storage"
+ ],
"override_compile_targets": [
"telemetry_gpu_test_run"
],
+ "precommit_args": [
+ "--download-refimg-from-cloud-storage"
+ ],
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
@@ -1042,17 +1060,26 @@
"--browser=debug",
"-v",
"--extra-browser-args=\"--enable-logging=stderr --js-flags=--expose-gc\"",
- "--upload-refimg-to-cloud-storage",
"--refimg-cloud-storage-bucket",
"chromium-gpu-archive/reference-images",
"--os-type",
- "linux"
+ "mac",
+ "--build-revision",
+ "${got_revision}",
+ "--test-machine-name",
+ "${buildername}"
],
"isolate_name": "telemetry_gpu_test",
"name": "pixel_test",
+ "non_precommit_args": [
+ "--upload-refimg-to-cloud-storage"
+ ],
"override_compile_targets": [
"telemetry_gpu_test_run"
],
+ "precommit_args": [
+ "--download-refimg-from-cloud-storage"
+ ],
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
@@ -1460,17 +1487,26 @@
"--browser=release",
"-v",
"--extra-browser-args=\"--enable-logging=stderr --js-flags=--expose-gc\"",
- "--upload-refimg-to-cloud-storage",
"--refimg-cloud-storage-bucket",
"chromium-gpu-archive/reference-images",
"--os-type",
- "linux"
+ "mac",
+ "--build-revision",
+ "${got_revision}",
+ "--test-machine-name",
+ "${buildername}"
],
"isolate_name": "telemetry_gpu_test",
"name": "pixel_test",
+ "non_precommit_args": [
+ "--upload-refimg-to-cloud-storage"
+ ],
"override_compile_targets": [
"telemetry_gpu_test_run"
],
+ "precommit_args": [
+ "--download-refimg-from-cloud-storage"
+ ],
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
@@ -1871,17 +1907,26 @@
"--browser=debug",
"-v",
"--extra-browser-args=\"--enable-logging=stderr --js-flags=--expose-gc\"",
- "--upload-refimg-to-cloud-storage",
"--refimg-cloud-storage-bucket",
"chromium-gpu-archive/reference-images",
"--os-type",
- "linux"
+ "win",
+ "--build-revision",
+ "${got_revision}",
+ "--test-machine-name",
+ "${buildername}"
],
"isolate_name": "telemetry_gpu_test",
"name": "pixel_test",
+ "non_precommit_args": [
+ "--upload-refimg-to-cloud-storage"
+ ],
"override_compile_targets": [
"telemetry_gpu_test_run"
],
+ "precommit_args": [
+ "--download-refimg-from-cloud-storage"
+ ],
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
@@ -2338,17 +2383,26 @@
"--browser=release",
"-v",
"--extra-browser-args=\"--enable-logging=stderr --js-flags=--expose-gc\"",
- "--upload-refimg-to-cloud-storage",
"--refimg-cloud-storage-bucket",
"chromium-gpu-archive/reference-images",
"--os-type",
- "linux"
+ "win",
+ "--build-revision",
+ "${got_revision}",
+ "--test-machine-name",
+ "${buildername}"
],
"isolate_name": "telemetry_gpu_test",
"name": "pixel_test",
+ "non_precommit_args": [
+ "--upload-refimg-to-cloud-storage"
+ ],
"override_compile_targets": [
"telemetry_gpu_test_run"
],
+ "precommit_args": [
+ "--download-refimg-from-cloud-storage"
+ ],
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698