add error handling if MediaCodec fails to decode data

add error handling if MediaCodec fails to decode data

If MediaCodec fails, we need to report the error to WMPA.

BUG=233420
R=acolwell@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202868

[qinmin, 2013-05-28 18:41:49]

PTAL

[acolwell GONE FROM CHROMIUM, 2013-05-28 20:35:20]

LGTM

https://codereview.chromium.org/15822006/diff/1/media/base/android/media_sour...
File media/base/android/media_source_player.cc (right):

https://codereview.chromium.org/15822006/diff/1/media/base/android/media_sour...
media/base/android/media_source_player.cc:103: // TODO(qinmin): figure out what
we should do if format changes.
nit: For now, you could make this case act like a decode error which might be
better than just ignoring it.

[qinmin, 2013-05-28 22:34:10]

https://codereview.chromium.org/15822006/diff/1/media/base/android/media_sour...
File media/base/android/media_source_player.cc (right):

https://codereview.chromium.org/15822006/diff/1/media/base/android/media_sour...
media/base/android/media_source_player.cc:103: // TODO(qinmin): figure out what
we should do if format changes.
Android MediaCodec will report INFO_OUTPUT_FORMAT_CHANGED when start decoding
the first frame. So if we report a decode error here, nothing will be decoded.
I think we should fix the TODO here: when format change happens, clear all the
data, recreate a MediaCodec, do a seek, and request a new surface. The user
experience will not be smooth, but that is probably the best we can do for JB.

On 2013/05/28 20:35:20, acolwell wrote:
> nit: For now, you could make this case act like a decode error which might be
> better than just ignoring it.

[acolwell GONE FROM CHROMIUM, 2013-05-28 22:39:38]

https://codereview.chromium.org/15822006/diff/1/media/base/android/media_sour...
File media/base/android/media_source_player.cc (right):

https://codereview.chromium.org/15822006/diff/1/media/base/android/media_sour...
media/base/android/media_source_player.cc:103: // TODO(qinmin): figure out what
we should do if format changes.
On 2013/05/28 22:34:10, qinmin wrote:
> Android MediaCodec will report INFO_OUTPUT_FORMAT_CHANGED when start decoding
> the first frame. So if we report a decode error here, nothing will be decoded.
> I think we should fix the TODO here: when format change happens, clear all the
> data, recreate a MediaCodec, do a seek, and request a new surface. The user
> experience will not be smooth, but that is probably the best we can do for JB.
> 
ok. I didn't realize this happens on the first frame. I thought this was only
related to changes after initial setup.

[commit-bot: I haz the power, 2013-05-28 23:46:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/qinmin@chromium.org/15822006/1

[commit-bot: I haz the power, 2013-05-29 00:16:47]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-05-29 03:35:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/qinmin@chromium.org/15822006/18002

[commit-bot: I haz the power, 2013-05-29 04:21:49]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[qinmin, 2013-05-29 14:39:31]

Committed patchset #3 manually as r202868 (presubmit successful).