Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: media/base/android/media_source_player.h

Issue 15822006: add error handling if MediaCodec fails to decode data (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: don't report error on format change Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/android/media_codec_bridge.h ('k') | media/base/android/media_source_player.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/android/media_source_player.h
diff --git a/media/base/android/media_source_player.h b/media/base/android/media_source_player.h
index 27b7b0c84bf37c5d5d6bb6ba7c791a935cc23227..2b6628fa958ec7c48aaf65f778290f61da2bc031 100644
--- a/media/base/android/media_source_player.h
+++ b/media/base/android/media_source_player.h
@@ -36,10 +36,11 @@ class MediaDecoderJob {
public:
virtual ~MediaDecoderJob();
- // Callback when a decoder job finishes its work. Args: presentation time,
- // timestamp when the data is rendered, whether decoder is reaching EOS.
- typedef base::Callback<void(const base::TimeDelta&, const base::Time&, bool)>
- DecoderCallback;
+ // Callback when a decoder job finishes its work. Args: whether decode
+ // finished successfully, presentation time, timestamp when the data is
+ // rendered, whether decoder is reaching EOS.
+ typedef base::Callback<void(bool, const base::TimeDelta&,
+ const base::Time&, bool)> DecoderCallback;
// Called by MediaSourcePlayer to decode some data.
void Decode(
@@ -155,7 +156,8 @@ class MEDIA_EXPORT MediaSourcePlayer : public MediaPlayerAndroid {
// Called when the decoder finishes its task.
void MediaDecoderCallback(
- bool is_audio, const base::TimeDelta& presentation_timestamp,
+ bool is_audio, bool decode_succeeded,
+ const base::TimeDelta& presentation_timestamp,
const base::Time& wallclock_time, bool end_of_stream);
// Handle pending events when all the decoder jobs finished.
« no previous file with comments | « media/base/android/media_codec_bridge.h ('k') | media/base/android/media_source_player.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698