Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 1581803009: Make RegARM32 a namespace rather than a class. (Closed)

Created:
4 years, 11 months ago by Karl
Modified:
4 years, 11 months ago
Reviewers:
Jim Stichnoth, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make RegARM32 a namespace rather than a class. Cleans up code by removing unnecessary class. BUG=None R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=57ec7dfe6beadff524101efbbe05e22baa0a0706

Patch Set 1 #

Patch Set 2 : Fix nits. #

Total comments: 6

Patch Set 3 : Fix nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -200 lines) Patch
M src/IceInstARM32.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/IceRegistersARM32.h View 1 2 1 chunk +147 lines, -195 lines 0 comments Download
M src/IceTargetLoweringARM32.h View 1 chunk +1 line, -1 line 0 comments Download
M src/IceTargetLoweringARM32.cpp View 1 2 3 chunks +45 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Karl
4 years, 11 months ago (2016-01-14 22:34:40 UTC) #3
Jim Stichnoth
otherwise lgtm https://codereview.chromium.org/1581803009/diff/20001/src/IceRegistersARM32.h File src/IceRegistersARM32.h (right): https://codereview.chromium.org/1581803009/diff/20001/src/IceRegistersARM32.h#newcode143 src/IceRegistersARM32.h:143: static inline IceString getGPRName(SizeT RegNum) { Remove ...
4 years, 11 months ago (2016-01-15 01:17:15 UTC) #4
Karl
Committed patchset #3 (id:40001) manually as 57ec7dfe6beadff524101efbbe05e22baa0a0706 (presubmit successful).
4 years, 11 months ago (2016-01-15 16:11:03 UTC) #6
Karl
4 years, 11 months ago (2016-01-15 16:11:20 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/1581803009/diff/20001/src/IceRegistersARM32.h
File src/IceRegistersARM32.h (right):

https://codereview.chromium.org/1581803009/diff/20001/src/IceRegistersARM32.h...
src/IceRegistersARM32.h:143: static inline IceString getGPRName(SizeT RegNum) {
On 2016/01/15 01:17:15, stichnot wrote:
> Remove this because it is identical to getRegName()
> 
> Also I think it's unused.

Done.

https://codereview.chromium.org/1581803009/diff/20001/src/IceRegistersARM32.h...
src/IceRegistersARM32.h:183: static inline IceString getSRegName(SizeT RegNum) {
On 2016/01/15 01:17:15, stichnot wrote:
> Remove this because it is identical to getRegName()

Done.

https://codereview.chromium.org/1581803009/diff/20001/src/IceTargetLoweringAR...
File src/IceTargetLoweringARM32.cpp (right):

https://codereview.chromium.org/1581803009/diff/20001/src/IceTargetLoweringAR...
src/IceTargetLoweringARM32.cpp:99: (SizeOf alias_init).size(), alias_init       
                    \
On 2016/01/15 01:17:15, stichnot wrote:
> I assume this trailing backslash alignment will get fixed by "make format"...

Done.

Powered by Google App Engine
This is Rietveld 408576698