Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1499)

Issue 1581753002: Remove Chrome OS-related GN build configuration (Closed)

Created:
4 years, 11 months ago by Petr Hosek
Modified:
4 years, 11 months ago
Reviewers:
viettrungluu
CC:
mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove Chrome OS-related GN build configuration We don't support Chrome OS, so no need for build configuration. R=viettrungluu@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/57ca940d8410a27fdf517b6194d7ecb0f29ecc2a

Patch Set 1 #

Total comments: 2

Patch Set 2 : Delete build/toolchain/cros #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -108 lines) Patch
M base/BUILD.gn View 1 5 chunks +5 lines, -9 lines 0 comments Download
M build/config/BUILDCONFIG.gn View 5 chunks +4 lines, -25 lines 0 comments Download
M build/config/compiler/BUILD.gn View 2 chunks +1 line, -9 lines 0 comments Download
M build/config/features.gni View 1 chunk +1 line, -1 line 0 comments Download
M build/config/linux/BUILD.gn View 1 chunk +0 lines, -6 lines 0 comments Download
M build/config/sysroot.gni View 2 chunks +2 lines, -2 lines 0 comments Download
M build/sanitizers/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M build/secondary/tools/grit/grit_rule.gni View 1 chunk +0 lines, -9 lines 0 comments Download
D build/toolchain/cros/BUILD.gn View 1 1 chunk +0 lines, -37 lines 0 comments Download
M third_party/breakpad/BUILD.gn View 1 3 chunks +3 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Petr Hosek
4 years, 11 months ago (2016-01-12 19:11:58 UTC) #4
viettrungluu
LGTM, though I think you can also delete all of //build/toolchain/cros. https://codereview.chromium.org/1581753002/diff/1/build/config/BUILDCONFIG.gn File build/config/BUILDCONFIG.gn (right): ...
4 years, 11 months ago (2016-01-12 22:47:11 UTC) #5
Petr Hosek
Removed. https://codereview.chromium.org/1581753002/diff/1/build/config/BUILDCONFIG.gn File build/config/BUILDCONFIG.gn (right): https://codereview.chromium.org/1581753002/diff/1/build/config/BUILDCONFIG.gn#newcode97 build/config/BUILDCONFIG.gn:97: is_desktop_linux = current_os == "linux" On 2016/01/12 22:47:11, ...
4 years, 11 months ago (2016-01-13 00:35:55 UTC) #7
Petr Hosek
4 years, 11 months ago (2016-01-13 02:26:42 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as
57ca940d8410a27fdf517b6194d7ecb0f29ecc2a.

Powered by Google App Engine
This is Rietveld 408576698