Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8119)

Unified Diff: build/config/compiler/BUILD.gn

Issue 1581753002: Remove Chrome OS-related GN build configuration (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Delete build/toolchain/cros Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/BUILDCONFIG.gn ('k') | build/config/features.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index bf2cdb325cbaf802ec6585ba339b96551c0097fd..01addd9cdfd66705868ea83c7cf1d7cb5edeaa69 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -104,8 +104,7 @@ config("compiler") {
}
# Linker warnings.
- if (!(is_chromeos && current_cpu == "arm") && !is_mac && !is_ios) {
- # TODO(jochen): Enable this on chromeos on arm. http://crbug.com/356580
+ if (!is_mac && !is_ios) {
ldflags += [ "-Wl,--fatal-warnings" ]
}
@@ -426,13 +425,6 @@ config("compiler") {
ldflags += [ "-Wl,--icf=all" ]
}
}
-
- # TODO(thestig): Make this flag work with GN.
- #if (!is_official_build && !is_chromeos && !(is_asan || is_lsan || is_tsan || is_msan)) {
- # ldflags += [
- # "-Wl,--detect-odr-violations",
- # ]
- #}
}
if (linux_use_bundled_binutils) {
« no previous file with comments | « build/config/BUILDCONFIG.gn ('k') | build/config/features.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698