DM test for YUV

DM test for YUV

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1581653003

[msarett, 2016-01-12 17:10:16]

Description was changed from

==========
DM test for YUV

BUG=skia:
==========

to

==========
DM test for YUV

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[scroggo, 2016-01-13 21:04:53]

scroggo@google.com changed reviewers:
+ scroggo@google.com

[scroggo, 2016-01-13 21:04:54]

https://codereview.chromium.org/1581653003/diff/1/dm/DMSrcSink.cpp
File dm/DMSrcSink.cpp (right):

https://codereview.chromium.org/1581653003/diff/1/dm/DMSrcSink.cpp#newcode245
dm/DMSrcSink.cpp:245: if (CodecSrc::kGetFromCanvas_DstColorType != fDstColorType
|| 1.0f != fScale) {
For the DstColorType, can we just limit creating CodecSrc to kGetFromCanvas?

For scale, I could imagine we just scale the canvas... maybe that's interesting
for comparison?

https://codereview.chromium.org/1581653003/diff/1/dm/DMSrcSink.cpp#newcode327
dm/DMSrcSink.cpp:327: return test_yuv(canvas, codec.detach());
Alternatively, you could let this method delete the codec (test_yuv will be
called before this method returns, so no need to pass ownership).

[msarett, 2016-01-15 18:57:35]

This has been merged with https://codereview.chromium.org/1549473003/.

https://codereview.chromium.org/1581653003/diff/1/dm/DMSrcSink.cpp
File dm/DMSrcSink.cpp (right):

https://codereview.chromium.org/1581653003/diff/1/dm/DMSrcSink.cpp#newcode245
dm/DMSrcSink.cpp:245: if (CodecSrc::kGetFromCanvas_DstColorType != fDstColorType
|| 1.0f != fScale) {
On 2016/01/13 21:04:54, scroggo wrote:
> For the DstColorType, can we just limit creating CodecSrc to kGetFromCanvas?
> 

Done.

> For scale, I could imagine we just scale the canvas... maybe that's
interesting
> for comparison?

This test has become a test of SkCodecImageGenerator.  I think it makes sense to
add scaling tests when we add scaling support to SkCodecImageGenerator.

https://codereview.chromium.org/1581653003/diff/1/dm/DMSrcSink.cpp#newcode327
dm/DMSrcSink.cpp:327: return test_yuv(canvas, codec.detach());
On 2016/01/13 21:04:54, scroggo wrote:
> Alternatively, you could let this method delete the codec (test_yuv will be
> called before this method returns, so no need to pass ownership).

Done.

[msarett, 2016-01-15 18:57:44]

Description was changed from

==========
DM test for YUV

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
DM test for YUV

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========