Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1581463002: Fix NTP after rotation in the tab switcher. (Closed)

Created:
4 years, 11 months ago by Ted C
Modified:
4 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2564
Target Ref:
refs/pending/branch-heads/2564
Project:
chromium
Visibility:
Public.

Description

Fix NTP after rotation in the tab switcher. Repro steps: 1.) Open NTP (in tabbed mode) 2.) Rotate landscape and scroll toolbar to top 3.) Long press on an NTP item and open in incognito 4.) Open tab switcher and switch back to normal stack 5.) Rotate to portrait 6.) Select NTP Turns out in this case an onScrollChanged is not broadcast from the scroll view so we need to push one ourselves. BUG=548088 Review URL: https://codereview.chromium.org/1460503005 Cr-Commit-Position: refs/heads/master@{#360734} Committed: https://chromium.googlesource.com/chromium/src/+/3e432b9da840998bac45dafb233e5f4b8c9ecae1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Ted C
4 years, 11 months ago (2016-01-11 22:17:10 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3e432b9da840998bac45dafb233e5f4b8c9ecae1.

Powered by Google App Engine
This is Rietveld 408576698