Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 1460503005: Fix NTP after rotation in the tab switcher. (Closed)

Created:
5 years, 1 month ago by Ted C
Modified:
5 years, 1 month ago
Reviewers:
newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix NTP after rotation in the tab switcher. Repro steps: 1.) Open NTP (in tabbed mode) 2.) Rotate landscape and scroll toolbar to top 3.) Long press on an NTP item and open in incognito 4.) Open tab switcher and switch back to normal stack 5.) Rotate to portrait 6.) Select NTP Turns out in this case an onScrollChanged is not broadcast from the scroll view so we need to push one ourselves. BUG=548088 Committed: https://crrev.com/d0a28226d7ba73ae2240dcbe12af1d8f2ed3b6c1 Cr-Commit-Position: refs/heads/master@{#360734}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Ted C
PTAL
5 years, 1 month ago (2015-11-19 22:05:52 UTC) #2
newt (away)
lgtm
5 years, 1 month ago (2015-11-19 22:27:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1460503005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1460503005/1
5 years, 1 month ago (2015-11-19 22:28:46 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, no build URL)
5 years, 1 month ago (2015-11-20 00:18:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1460503005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1460503005/1
5 years, 1 month ago (2015-11-20 01:46:39 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-20 03:30:51 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 03:32:03 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d0a28226d7ba73ae2240dcbe12af1d8f2ed3b6c1
Cr-Commit-Position: refs/heads/master@{#360734}

Powered by Google App Engine
This is Rietveld 408576698