Issue 25064. Incrementally resolve comments only if both are documentation.

Issue 25064. Incrementally resolve comments only if both are documentation.

R=brianwilkerson@google.com, skybrian@google.com
BUG= https://github.com/dart-lang/sdk/issues/25064

Committed: https://github.com/dart-lang/sdk/commit/9484bfe1c92c77dc01471a01d2adda12bebf03a6

[skybrian, 2016-01-14 02:33:11]

skybrian@google.com changed reviewers:
+ skybrian@google.com

[skybrian, 2016-01-14 02:33:12]

lgtm

https://codereview.chromium.org/1581293002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/incremental_resolver.dart (right):

https://codereview.chromium.org/1581293002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/incremental_resolver.dart:1597: Comment
oldComment = _findNodeCovering(_oldUnit, offset, offset);
In addition, I suggest changing these two lines:

var oldComment = _findNodeCovering(_oldUnit, offset, offset) as Comment;
var newComment = _findNodeCovering(newUnit, offset, offset) as Comment;

That way the downcast will be checked in production.

[skybrian, 2016-01-14 02:39:13]

https://codereview.chromium.org/1581293002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/incremental_resolver.dart (left):

https://codereview.chromium.org/1581293002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/incremental_resolver.dart:1560:
logger.log('Failure: exception.');
Another suggestion:

+      // The incremental resolver log is usually turned off,
+      // so also log the exception to the instrumentation log.
+      AnalysisEngine.instance.logger.logError(
+          'failure in incremental resolver', new CaughtException(e, st));

[scheglov, 2016-01-14 03:19:30]

https://codereview.chromium.org/1581293002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/incremental_resolver.dart (right):

https://codereview.chromium.org/1581293002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/incremental_resolver.dart:1597: Comment
oldComment = _findNodeCovering(_oldUnit, offset, offset);
On 2016/01/14 02:33:11, skybrian wrote:
> In addition, I suggest changing these two lines:
> 
> var oldComment = _findNodeCovering(_oldUnit, offset, offset) as Comment;
> var newComment = _findNodeCovering(newUnit, offset, offset) as Comment;
> 
> That way the downcast will be checked in production.

Done.

[Brian Wilkerson, 2016-01-14 14:51:48]

LGTM

https://codereview.chromium.org/1581293002/diff/20001/pkg/analyzer/test/gener...
File pkg/analyzer/test/generated/incremental_resolver_test.dart (right):

https://codereview.chromium.org/1581293002/diff/20001/pkg/analyzer/test/gener...
pkg/analyzer/test/generated/incremental_resolver_test.dart:13: import
'package:analyzer/src/generated/incremental_logger.dart' as lg;
I don't understand why you changed the prefix from a word to a string of
unreadable characters.

[scheglov, 2016-01-14 16:38:42]

Description was changed from

==========
Issue 25064. Incrementally resolve comments only if both are documentation.

R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25064
==========

to

==========
Issue 25064. Incrementally resolve comments only if both are documentation.

R=brianwilkerson@google.com, skybrian@google.com
BUG= https://github.com/dart-lang/sdk/issues/25064

Committed:
https://github.com/dart-lang/sdk/commit/9484bfe1c92c77dc01471a01d2adda12bebf03a6
==========

[scheglov, 2016-01-14 16:38:43]

Committed patchset #2 (id:20001) manually as
9484bfe1c92c77dc01471a01d2adda12bebf03a6 (presubmit successful).